Create company automatically from contact #4954
Replies: 13 comments
-
|
Hey @FelixMalfait |
Beta Was this translation helpful? Give feedback.
-
|
There's an issue what if the input email is invalid. Is there a check for that? |
Beta Was this translation helpful? Give feedback.
-
|
Should this be part of a Workflows V1? We could create a workflow tab in settings to display the automation (non editable) |
Beta Was this translation helpful? Give feedback.
-
|
@Bonapara probably when we build workflow we can migrate it there yes. But I feel like this is a relatively simple task to implement VS implementing workflows = months of work. @Kanav-Arora thanks a lot. Is the issue clear enough? I think we already handle invalid email input. This is purely on the backend side. |
Beta Was this translation helpful? Give feedback.
-
|
@FelixMalfait yeah |
Beta Was this translation helpful? Give feedback.
-
|
Hi @FelixMalfait , can I work on this please? |
Beta Was this translation helpful? Give feedback.
-
I have some pending issues to cover, you can work on this one. I haven't started it yet |
Beta Was this translation helpful? Give feedback.
-
|
@karishma-shah this one my be a bit hard for a first issue (Kanav had some experience with other issues priori to his). You can look for issues with the tag "good first issue". I see you've just done that today on already 🙏. There are many different ways we could go to implement this, and I didn't give enough context in the initial ticket. We have a moved to a new backend that creates layer of abstractions in the way we manage objects. BackendEnrichment endpoint Layout
Frontend
But this would need an internal discussion with @charlesBochet and team first, because we would be setting the first stone of the "layout framework" which will be an important piece |
Beta Was this translation helpful? Give feedback.
-
|
Hi @FelixMalfait |
Beta Was this translation helpful? Give feedback.
-
|
Hi @Kanav-Arora @FelixMalfait, no worries! I think it would be best if i picked up an issue with 'good first issue' tag for now instead. |
Beta Was this translation helpful? Give feedback.
-
|
@Kanav-Arora thanks I just created a dedicated issue to make sure we have a plan on layout, you can follow it here #2910 |
Beta Was this translation helpful? Give feedback.
-
|
@FelixMalfait is it still relevant, if so, should it be added as an additional step in flow of enrichment app or created as a separate app? |
Beta Was this translation helpful? Give feedback.
-
|
Closing as it's done in #18909 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
When we create a contact, if that contact doesn't have a company, then we should create the company automatically from the domain name.
You can use: https://gist.github.com/ammarshah/f5c2624d767f91a7cbdc4e54db8dd0bf
Beta Was this translation helpful? Give feedback.
All reactions