Skip to content

TypedDataArray string constructor escape character #4

@adam-parker1

Description

@adam-parker1

In TypedDataArray.hpp the constructor with a string argument has +1 on the size and shape for an escape character

: m_type_index{typeid(char)}, m_size{value.size() + 1}, m_shape{value.size() + 1}, m_owning{true}

I dont think it is actually needed, leads to:

── loop[0]/element[9]
    ├── name: 'centrecolumn_E10\x00'
    ├── identifier: 'centrecolumn_L1_E10\x00'

No problems when changing to m_size{value.size()}, m_shape{value.size()}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions