Skip to content

Commit 4605f5c

Browse files
committed
Fix mobile UI/UX issues
1 parent 5144aff commit 4605f5c

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

src/app/(main)/MobileNav.tsx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,13 @@ export function MobileNav() {
4949
<MobileMenuButton>
5050
{({ close }) => {
5151
return (
52-
<Column gap="2" display="flex" flex-direction="column" height="100vh" padding="1">
52+
<Column
53+
gap="2"
54+
display="flex"
55+
flex-direction="column"
56+
padding="1"
57+
style={{ height: '100dvh' }}
58+
>
5359
{isMain &&
5460
links.map(link => {
5561
return (
@@ -63,8 +69,8 @@ export function MobileNav() {
6369
{websiteId && <WebsiteNav websiteId={websiteId} onItemClick={close} />}
6470
{isAdmin && <AdminNav onItemClick={close} />}
6571
{isSettings && <SettingsNav onItemClick={close} />}
66-
<Row onClick={close} style={{ marginTop: 'auto' }}>
67-
<UserButton />
72+
<Row style={{ marginTop: 'auto' }}>
73+
<UserButton onClose={close} />
6874
</Row>
6975
</Column>
7076
);

src/app/(main)/websites/[websiteId]/settings/SharesTable.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export function SharesTable(props: DataTableProps) {
1818
};
1919

2020
return (
21-
<DataTable {...props}>
21+
<DataTable {...props} displayMode={isMobile ? 'cards' : 'table'}>
2222
<DataColumn id="name" label={t(labels.name)}>
2323
{({ name }: any) => name}
2424
</DataColumn>
@@ -27,16 +27,14 @@ export function SharesTable(props: DataTableProps) {
2727
const url = getUrl(slug);
2828
return (
2929
<ExternalLink href={url} prefetch={false}>
30-
{url}
30+
{isMobile ? slug : url}
3131
</ExternalLink>
3232
);
3333
}}
3434
</DataColumn>
35-
{!isMobile && (
36-
<DataColumn id="created" label={t(labels.created)}>
37-
{(row: any) => <DateDistance date={new Date(row.createdAt)} />}
38-
</DataColumn>
39-
)}
35+
<DataColumn id="created" label={t(labels.created)}>
36+
{(row: any) => <DateDistance date={new Date(row.createdAt)} />}
37+
</DataColumn>
4038
<DataColumn id="action" align="end" width="100px">
4139
{({ id, slug }: any) => {
4240
return (

src/components/input/UserButton.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,10 @@ import { languages } from '@/lib/lang';
3333

3434
export interface UserButtonProps {
3535
showText?: boolean;
36+
onClose?: () => void;
3637
}
3738

38-
export function UserButton({ showText = true }: UserButtonProps) {
39+
export function UserButton({ showText = true, onClose }: UserButtonProps) {
3940
const { user } = useLoginQuery();
4041
const { cloudMode } = useConfig();
4142
const { t, labels } = useMessages();
@@ -111,7 +112,7 @@ export function UserButton({ showText = true }: UserButtonProps) {
111112
</TooltipTrigger>
112113
<Popover placement="top start">
113114
<Column minWidth="200px">
114-
<Menu autoFocus="last">
115+
<Menu autoFocus="last" onAction={onClose}>
115116
<MenuItem id="settings" href={getUrl('/settings')}>
116117
<Row alignItems="center" gap>
117118
<Icon>

0 commit comments

Comments
 (0)