-
-
Notifications
You must be signed in to change notification settings - Fork 57
UAE Dirham sign version 2 #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the UAE Dirham Sign character (U+20C3) to Unicode Version 17.0, following the UTC consensus decision [184-C17] to encode this currency symbol in the Currency Symbols block.
- Adds the new UAE DIRHAM SIGN character with Unicode codepoint 20C3
- Updates all relevant Unicode data files with appropriate properties for the new character
- Includes comparison testing configuration to verify the character properties match expected patterns
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
232.txt | Adds property comparison tests for the new UAE DIRHAM SIGN character |
DerivedName.txt | Adds the character name mapping for U+20C3 |
DerivedLineBreak.txt | Assigns line break property PR (Prefix) to the new character |
DerivedGeneralCategory.txt | Assigns general category Sc (Symbol, currency) to the new character |
DerivedEastAsianWidth.txt | Assigns East Asian width property N (Neutral) to the new character |
DerivedCombiningClass.txt | Assigns combining class 0 (non-combining) to the new character |
DerivedBidiClass.txt | Assigns bidirectional class ET (European Number Terminator) to the new character |
VerticalOrientation.txt | Assigns vertical orientation property R (Rotate) to the new character |
UnicodeData.txt | Adds the complete character definition with all basic properties |
Scripts.txt | Assigns script property Common to the new character |
LineBreak.txt | Updates line break property assignments to include the new character |
EastAsianWidth.txt | Updates East Asian width property assignments to include the new character |
DerivedCoreProperties.txt | Assigns core property Grapheme_Base to the new character |
DerivedAge.txt | Assigns age property 17.0 to the new character |
unicodetools/src/main/resources/org/unicode/text/UCD/AdditionComparisons/232.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for this stage
I think we just ignore the IDNA test failure until this PR is merged and we then also regenerate the data files for idna/security/uca.
See https://github.com/unicode-org/sah/issues/650 and L2/25-159,
[184-C17] Consensus: UTC accepts U+20C3 UAE DIRHAM SIGN for encoding in the Currency Symbols block based on L2/25-159, for Unicode Version 18.0. [Ref. 2.1 in L2/25-187]
https://github.com/unicode-org/utc-release-management/issues/232