fix(delay): keep percentage deviations in the written form

Author: unkn0wn-root

internal/delay/delay.go

@@ -14,12 +14,13 @@ import (
 // Spec is one parsed delay expression; the zero value never delays. What base
 // and spread hold depends on the kind: the constant delay, the bounds of
 // random, or a center and the deviation around it. A deviation written as a
-// percentage stays one so the text round-trips.
+// percentage is marked relative so the text round-trips.
 type Spec struct {
 	kind   kind
 	base   time.Duration
 	spread time.Duration
 	pct    float64
+	rel    bool
 }
 
 func Fixed(d time.Duration) Spec {
@@ -64,7 +65,7 @@ func Parse(raw string) (Spec, error) {
 	case err != nil:
 		return Spec{}, err
 	case relative:
-		s.pct = pct
+		s.pct, s.rel = pct, true
 	default:
 		if s.spread, err = f.duration(1, args[1]); err != nil {
 			return Spec{}, err
@@ -105,14 +106,14 @@ func (s Spec) String() string {
 }
 
 func (s Spec) argText() string {
-	if s.pct > 0 {
-		return strconv.FormatFloat(s.pct, 'f', -1, 64) + "%"
+	if s.rel {
+		return strconv.FormatFloat(s.pct, 'g', -1, 64) + "%"
 	}
 	return s.spread.String()
 }
 
 func (s Spec) deviation() time.Duration {
-	if s.pct > 0 {
+	if s.rel {
 		return clamp(float64(s.base) * s.pct / 100)
 	}
 	return s.spread
@@ -139,36 +140,22 @@ func (s *Spec) UnmarshalText(text []byte) error {
 
 // Descriptor is one distribution as documentation and completions see it.
 type Descriptor struct {
-	name    string
-	summary string
-	args    string
-}
-
-func (d Descriptor) Name() string {
-	return d.name
-}
-
-func (d Descriptor) Summary() string {
-	return d.summary
+	Name    string
+	Summary string
+	Args    string
 }
 
 // Usage is the example call, e.g. random(100ms,500ms).
 func (d Descriptor) Usage() string {
-	return call(d.name, d.args)
-}
-
-// Args is the example argument list of Usage without the parentheses, so a
-// caller offering the usage as a template knows what part of it to fill in.
-func (d Descriptor) Args() string {
-	return d.args
+	return call(d.Name, d.Args)
 }
 
 // Distributions describes the call forms, in documentation order.
 func Distributions() []Descriptor {
 	out := make([]Descriptor, 0, len(forms)-1)
 	for _, f := range forms {
 		if f.name != "" {
-			out = append(out, Descriptor{name: f.name, summary: f.summary, args: f.args})
+			out = append(out, Descriptor{Name: f.name, Summary: f.summary, Args: f.args})
 		}
 	}
 	return out

internal/delay/delay_test.go

@@ -45,6 +45,8 @@ func TestParseText(t *testing.T) {
 		{input: "normal(250ms,20%)", want: "normal(250ms,20%)"},
 		{input: "jitter(200ms,20%)", want: "jitter(200ms,20%)"},
 		{input: "jitter(200ms,12.5%)", want: "jitter(200ms,12.5%)"},
+		{input: "normal(250ms,0%)", want: "normal(250ms,0%)"},
+		{input: "normal(250ms,1e300%)", want: "normal(250ms,1e+300%)"},
 		{input: "jitter(200ms,20ms)", want: "jitter(200ms,20ms)"},
 	}
 
@@ -240,7 +242,7 @@ func TestDistributions(t *testing.T) {
 		t.Fatal("no distributions described")
 	}
 	for _, f := range forms {
-		if f.Name() == "" || f.Summary() == "" {
+		if f.Name == "" || f.Summary == "" {
 			t.Fatalf("incomplete descriptor %+v", f)
 		}
 		s := mustParse(t, f.Usage())

internal/intellisense/directives.go

@@ -76,10 +76,10 @@ func mockItems() []Item {
 	}
 	for _, d := range delay.Distributions() {
 		items = append(items, Item{
-			Label:       "latency=" + d.Name(),
-			Summary:     d.Summary(),
+			Label:       "latency=" + d.Name,
+			Summary:     d.Summary,
 			Insert:      "latency=" + d.Usage(),
-			Placeholder: d.Args(),
+			Placeholder: d.Args,
 		})
 	}
 	return append(items, Item{

internal/intellisense/directives_test.go

@@ -117,7 +117,7 @@ func TestMockLatencyArgsCoverEveryDistribution(t *testing.T) {
 		t.Fatalf("mock args missing the constant latency: %v", mock)
 	}
 	for _, d := range delay.Distributions() {
-		label := "latency=" + d.Name()
+		label := "latency=" + d.Name
 		found := false
 		for _, it := range mock {
 			if it.Label != label {
@@ -128,8 +128,8 @@ func TestMockLatencyArgsCoverEveryDistribution(t *testing.T) {
 				t.Fatalf("%s inserts %q, want the %q example", label, it.Insert, d.Usage())
 			}
 			// The arguments are typed over, the parentheses around them are not.
-			if it.Placeholder != d.Args() {
-				t.Fatalf("%s selects %q, want the %q arguments", label, it.Placeholder, d.Args())
+			if it.Placeholder != d.Args {
+				t.Fatalf("%s selects %q, want the %q arguments", label, it.Placeholder, d.Args)
 			}
 			start, end, ok := it.PlaceholderRange()
 			if !ok {
@@ -138,8 +138,8 @@ func TestMockLatencyArgsCoverEveryDistribution(t *testing.T) {
 			if got := []rune(it.Insert)[end:]; string(got) != ")" {
 				t.Fatalf("%s selects up to %q, want the closing paren left out", label, string(got))
 			}
-			if got := []rune(it.Insert)[start:end]; string(got) != d.Args() {
-				t.Fatalf("%s selects %q, want %q", label, string(got), d.Args())
+			if got := []rune(it.Insert)[start:end]; string(got) != d.Args {
+				t.Fatalf("%s selects %q, want %q", label, string(got), d.Args)
 			}
 		}
 		if !found {