moved lookup of generic keyword parameters to declaration site of a constructor, such that it can be kept static and reused between field accesses (#2417)

* added generic keyword parameter cache as an experiment

* clear kwparam cache when reloading

Author: jurgenvinju

src/org/rascalmpl/interpreter/env/ModuleEnvironment.java

@@ -78,10 +78,11 @@ public class ModuleEnvironment extends Environment {
 	private boolean bootstrap;
 	private String deprecated;
 	protected Map<String, AbstractFunction> resourceImporters;
+	protected Map<Type, Set<GenericKeywordParameters>> cachedGeneralKeywordParameters;
 
 	protected static final TypeFactory TF = TypeFactory.getInstance();
 
-	public final static String SHELL_MODULE = "$shell$";
+	public final static String SHELL_MODULE = "$";
 
 	public ModuleEnvironment(String name, GlobalEnvironment heap) {
 		super(ValueFactoryFactory.getValueFactory().sourceLocation(URIUtil.assumeCorrect("main", name, "")), name);
@@ -95,6 +96,7 @@ public ModuleEnvironment(String name, GlobalEnvironment heap) {
 		this.syntaxDefined = false;
 		this.bootstrap = false;
 		this.resourceImporters = new HashMap<String, AbstractFunction>();
+		this.cachedGeneralKeywordParameters = null;
 	}
 
 	/**
@@ -113,25 +115,27 @@ protected ModuleEnvironment(ModuleEnvironment env) {
 		this.syntaxDefined = env.syntaxDefined;
 		this.bootstrap = env.bootstrap;
 		this.resourceImporters = env.resourceImporters;
+		this.cachedGeneralKeywordParameters = null;
 		this.deprecated = env.deprecated;
 	}
 
 	@Override
 	public void reset() {
 		super.reset();
-		this.importedModules = new HashSet<String>();
-		this.concreteSyntaxTypes = new HashMap<String, NonTerminalType>();
+		this.importedModules = new HashSet<>();
+		this.concreteSyntaxTypes = new HashMap<>();
 		this.typeStore = new TypeStore();
 		this.productions = new HashSet<IValue>();
 		this.initialized = false;
 		this.syntaxDefined = false;
 		this.bootstrap = false;
 		this.extended = new HashSet<String>();
 		this.deprecated = null;
+		this.generalKeywordParameters = new HashMap<>();
+		this.cachedGeneralKeywordParameters = null;
 	}
 
 	public void extend(ModuleEnvironment other) {
-//	  super.extend(other);
 		extendNameFlags(other);
 
 	  // First extend the imports before functions and variables
@@ -386,10 +390,12 @@ public void unImport(String moduleName) {
 				typeStore.unimportStores(new TypeStore[] { old.getStore() });
 			}
 		}
+		cachedGeneralKeywordParameters = null;
 	}
 
 	public void unExtend(String moduleName) {
 		extended.remove(moduleName);
+		cachedGeneralKeywordParameters = null;
 	}
 
 	@Override
@@ -710,6 +716,16 @@ public List<KeywordFormal> getFormals() {
 
 	@Override
 	public Set<GenericKeywordParameters> lookupGenericKeywordParameters(Type adt) {
+		if (cachedGeneralKeywordParameters != null) {
+			var result = cachedGeneralKeywordParameters.get(adt);
+			if (result != null) {
+				return result;
+			}
+		}
+		else {
+			cachedGeneralKeywordParameters = io.usethesource.capsule.Map.Transient.of();
+		}
+
 		Set<GenericKeywordParameters> result = new HashSet<>();
 		List<KeywordFormal> list = generalKeywordParameters.get(adt);
 		if (list != null) {
@@ -725,6 +741,9 @@ public Set<GenericKeywordParameters> lookupGenericKeywordParameters(Type adt) {
 			}
 		}
 
+		// save the result for next time
+		cachedGeneralKeywordParameters.put(adt, result);
+
 		return result;
 	}