Fix: Stop hardcoding exact Nominatim geocoding coordinates in e2e tests (#1619)

verify_the_map_coordinates and fill_required_form_fields both asserted
an exact lat/lng string for a "Nairobi County" geocoder search. That
value is returned by the live Nominatim/OSM API, not fixed test data,
and its centroid for large administrative areas drifts as OSM boundary
data gets edited over time (confirmed by querying the API directly:
it currently returns -1.302398 for this query, not the hardcoded
-1.3026148499999999). Assert the result lands within Nairobi instead
of matching an exact string, so the test survives normal upstream
geocoding data changes.


Claude-Session: https://claude.ai/code/session_0142M19Se37Y1pxoNy8HvTKV

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Author: tuxpiper

e2e-testing/cypress/functions/GeneralSettingsFunctions.js

@@ -73,8 +73,15 @@ class GeneralSettingsFunctions {
       .eq(0)
       .click();
     cy.wait(1000);
-    cy.get(GeneralSettingsLocator.defaultLatitudeField).should('have.value', '-1.3026148499999999');
-    cy.get(GeneralSettingsLocator.defaultLongitudeField).should('have.value', '36.82884201813725');
+    // The geocoder (Nominatim/OSM) can return a slightly different centroid for a large
+    // administrative area like "Nairobi County" as the underlying OSM boundary data is
+    // edited over time, so assert the result lands within Nairobi rather than an exact value.
+    cy.get(GeneralSettingsLocator.defaultLatitudeField).should(($el) => {
+      expect(parseFloat($el.val())).to.be.closeTo(-1.3, 0.15);
+    });
+    cy.get(GeneralSettingsLocator.defaultLongitudeField).should(($el) => {
+      expect(parseFloat($el.val())).to.be.closeTo(36.83, 0.15);
+    });
   }
 
   steps_to_generate_new_api_key() {

e2e-testing/cypress/functions/PostsFunctions/PostFunctions.js

@@ -31,9 +31,15 @@ class PostFunctions {
 
     //type in nairobi county in full. this gets one result and picks it automatically, populating lat and long fields
     cy.get(PostLocators.locationSearchField).type('nairobi county');
-    //verify values in lat and long fields
-    cy.get(PostLocators.locationLatField).should('have.value', '-1.3026148499999999');
-    cy.get(PostLocators.locationLongField).should('have.value', '36.82884201813725');
+    //verify values in lat and long fields land within Nairobi. Not an exact match because the
+    //geocoder (Nominatim/OSM) can return a slightly different centroid over time as the
+    //underlying OSM boundary data is edited.
+    cy.get(PostLocators.locationLatField).should(($el) => {
+      expect(parseFloat($el.val())).to.be.closeTo(-1.3, 0.15);
+    });
+    cy.get(PostLocators.locationLongField).should(($el) => {
+      expect(parseFloat($el.val())).to.be.closeTo(36.83, 0.15);
+    });
 
     // click on date field to open pop up
     // cy.get(PostLocators.dateField).click(); //the first click opens the date picker