Skip to content

Commit 42c1124

Browse files
committed
Fixed numeric timelines no filter bug
1 parent 084dd22 commit 42c1124

File tree

2 files changed

+19
-15
lines changed

2 files changed

+19
-15
lines changed

src/server/Model/Compiler/Common/ConceptDatasetSqlSet.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ internal override void SetSelect()
4141
cols.Add(encounterId);
4242
cols.Add(dateField);
4343

44-
if (PanelItem != null && PanelItem.Concept.IsNumeric)
44+
if (PanelItem != null && PanelItem.UseNumericFilter)
4545
{
4646
var numericField = new ExpressedColumn(Number, ConceptColumns.NumberField);
4747
cols.Add(numericField);

src/ui-client/src/components/Timelines/AggregateTimelineChart.tsx

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -206,19 +206,23 @@ class CustomizedYAxisTick extends React.PureComponent<YTickProps> {
206206
let coreText = pi.concept.uiDisplayText;
207207
let addText = '';
208208

209-
if (pi.numericFilter.filterType !== NumericFilterType.None) {
210-
const f = pi.numericFilter.filter;
211-
switch (pi.numericFilter.filterType) {
212-
case NumericFilterType.GreaterThan: addText = `> ${f[0]}`; break;
213-
case NumericFilterType.GreaterThanOrEqualTo: addText = `>= ${f[0]}`; break;
214-
case NumericFilterType.LessThan: addText = `< ${f[0]}`; break;
215-
case NumericFilterType.LessThanOrEqualTo: addText = `<= ${f[0]}`; break;
216-
case NumericFilterType.EqualTo: addText = `= ${f[0]}`; break;
217-
case NumericFilterType.GreaterThanOrEqualTo: addText = `>=${f[0]}`; break;
218-
case NumericFilterType.Between: addText = `between ${f[0]} and ${f[1]}`; break;
219-
}
220-
if (pi.concept.uiDisplayUnits) {
221-
addText += ` ${pi.concept.uiDisplayUnits}`
209+
if (concept.isNumeric) {
210+
if (pi.numericFilter.filterType !== NumericFilterType.None) {
211+
const f = pi.numericFilter.filter;
212+
switch (pi.numericFilter.filterType) {
213+
case NumericFilterType.GreaterThan: addText = `> ${f[0]}`; break;
214+
case NumericFilterType.GreaterThanOrEqualTo: addText = `>= ${f[0]}`; break;
215+
case NumericFilterType.LessThan: addText = `< ${f[0]}`; break;
216+
case NumericFilterType.LessThanOrEqualTo: addText = `<= ${f[0]}`; break;
217+
case NumericFilterType.EqualTo: addText = `= ${f[0]}`; break;
218+
case NumericFilterType.GreaterThanOrEqualTo: addText = `>=${f[0]}`; break;
219+
case NumericFilterType.Between: addText = `between ${f[0]} and ${f[1]}`; break;
220+
}
221+
if (concept.uiDisplayUnits) {
222+
addText += ` ${pi.concept.uiDisplayUnits}`
223+
}
224+
} else if (concept.uiNumericDefaultText) {
225+
addText += ` ${concept.uiNumericDefaultText}`
222226
}
223227
}
224228
if (concept.isSpecializable && concept.specializationGroups) {
@@ -234,7 +238,7 @@ class CustomizedYAxisTick extends React.PureComponent<YTickProps> {
234238
addText += ` (${panel.dateFilter.display.replace('In ', '')})`;
235239
}
236240

237-
const shortenVal = addText.length ? 50 : 60;
241+
const shortenVal = addText.length ? 70 : 80;
238242
if (coreText.length > shortenVal) {
239243
coreText = `${coreText.slice(0, shortenVal)} ...`
240244
}

0 commit comments

Comments
 (0)