fix(shell): add error handling and proper quoting to run_tests.sh

- Add set -euo pipefail for strict error handling
- Quote all variable references ($KUBECONFIG, $KUBECONFIG_EDGE, $WORKSPACE)
- Use ${VAR:-} syntax for unset variable checks with set -u
- Use mktemp -d instead of /tmp for secure temporary directory
- Tests will now fail fast on any error instead of continuing

Author: brianredbeard

tests/interop/run_tests.sh

@@ -1,36 +1,39 @@
 #!/usr/bin/bash
+set -euo pipefail
 
 export EXTERNAL_TEST="true"
 export PATTERN_NAME="MultiCloudGitops"
 export PATTERN_SHORTNAME="mcgitops"
 
-if [ -z "${KUBECONFIG}" ]; then
+if [ -z "${KUBECONFIG:-}" ]; then
     echo "No kubeconfig file set for hub cluster"
     exit 1
 fi
 
-if [ -z "${KUBECONFIG_EDGE}" ]; then
+if [ -z "${KUBECONFIG_EDGE:-}" ]; then
     echo "No kubeconfig file set for edge cluster"
     exit 1
 fi
 
-if [ -z "${INFRA_PROVIDER}" ]; then
+if [ -z "${INFRA_PROVIDER:-}" ]; then
     echo "INFRA_PROVIDER is not defined"
     exit 1
 fi
 
-if [ -z "${WORKSPACE}" ]; then
-    export WORKSPACE=/tmp
+if [ -z "${WORKSPACE:-}" ]; then
+    WORKSPACE=$(mktemp -d)
+    export WORKSPACE
+    echo "WORKSPACE not set, using temporary directory: ${WORKSPACE}"
 fi
 
-pytest -lv --disable-warnings test_subscription_status_hub.py --kubeconfig $KUBECONFIG --junit-xml $WORKSPACE/test_subscription_status_hub.xml
+pytest -lv --disable-warnings test_subscription_status_hub.py --kubeconfig "$KUBECONFIG" --junit-xml "$WORKSPACE/test_subscription_status_hub.xml"
 
-pytest -lv --disable-warnings test_subscription_status_edge.py --kubeconfig $KUBECONFIG_EDGE --junit-xml $WORKSPACE/test_subscription_status_edge.xml
+pytest -lv --disable-warnings test_subscription_status_edge.py --kubeconfig "$KUBECONFIG_EDGE" --junit-xml "$WORKSPACE/test_subscription_status_edge.xml"
 
-pytest -lv --disable-warnings test_validate_hub_site_components.py --kubeconfig $KUBECONFIG --junit-xml $WORKSPACE/test_validate_hub_site_components.xml
+pytest -lv --disable-warnings test_validate_hub_site_components.py --kubeconfig "$KUBECONFIG" --junit-xml "$WORKSPACE/test_validate_hub_site_components.xml"
 
-pytest -lv --disable-warnings test_validate_edge_site_components.py --kubeconfig $KUBECONFIG_EDGE --junit-xml $WORKSPACE/test_validate_edge_site_components.xml
+pytest -lv --disable-warnings test_validate_edge_site_components.py --kubeconfig "$KUBECONFIG_EDGE" --junit-xml "$WORKSPACE/test_validate_edge_site_components.xml"
 
-pytest -lv --disable-warnings test_modify_web_content.py --kubeconfig $KUBECONFIG --junit-xml $WORKSPACE/test_modify_web_content.xml
+pytest -lv --disable-warnings test_modify_web_content.py --kubeconfig "$KUBECONFIG" --junit-xml "$WORKSPACE/test_modify_web_content.xml"
 
 python3 create_ci_badge.py