Fix RDMA + IO threads re-entrancy via connection postpone masks (9.0) #804
Workflow file for this run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: On-demand Benchmark | |
| on: | |
| pull_request_target: | |
| types: [labeled] | |
| concurrency: | |
| group: valkey-benchmark | |
| cancel-in-progress: false | |
| defaults: | |
| run: | |
| shell: "bash -Eeuo pipefail -x {0}" | |
| permissions: | |
| contents: read | |
| pull-requests: write | |
| issues: write | |
| jobs: | |
| benchmark: | |
| runs-on: ${{ github.repository == 'valkey-io/valkey' && fromJSON('["self-hosted","ec2-ubuntu-24.04-benchmarking"]') || 'ubuntu-latest' }} | |
| if: | | |
| github.event.action == 'labeled' && github.event.label.name == 'run-benchmark' | |
| steps: | |
| - name: Checkout valkey | |
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | |
| with: | |
| path: valkey | |
| fetch-depth: 0 | |
| ref: ${{ github.event.pull_request.merge_commit_sha }} | |
| persist-credentials: false | |
| - name: Checkout valkey-perf-benchmark | |
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | |
| with: | |
| repository: ${{ github.repository_owner }}/valkey-perf-benchmark | |
| path: valkey-perf-benchmark | |
| fetch-depth: 1 | |
| persist-credentials: false | |
| - name: Set up Python | |
| uses: kishaningithub/setup-python-amazon-linux@a326cdc792983fe0fbd04c81d3d62b59b6123a6c # v1.1.0 | |
| with: | |
| python-version: "3.10" | |
| cache: "pip" | |
| - name: Install dependencies | |
| working-directory: valkey-perf-benchmark | |
| run: | | |
| sudo apt-get update | |
| sudo apt-get install -y build-essential | |
| pip install -r requirements.txt | |
| - name: Run benchmarks | |
| working-directory: valkey-perf-benchmark | |
| run: | | |
| CONFIG_FILE="../valkey/.github/benchmark_configs/pr_benchmark.json" | |
| # Removes server/client CPU range args if running in private repo | |
| if [[ "${{ github.repository }}" != "valkey-io/valkey" ]]; then | |
| jq 'map(del(.server_cpu_range, .client_cpu_range))' "$CONFIG_FILE" > tmp.json && mv tmp.json "$CONFIG_FILE" | |
| fi | |
| # Base benchmark arguments | |
| BENCHMARK_ARGS=( | |
| --commits "${{ github.event.pull_request.merge_commit_sha }}" | |
| --baseline "${{ github.event.pull_request.base.ref }}" | |
| --results-dir "results" | |
| --valkey-path "../valkey" | |
| --config "$CONFIG_FILE" | |
| ) | |
| # Run benchmark | |
| python ./benchmark.py "${BENCHMARK_ARGS[@]}" | |
| - name: Compare results | |
| working-directory: valkey-perf-benchmark | |
| run: | | |
| python ./utils/compare_benchmark_results.py \ | |
| ./results/${{ github.event.pull_request.base.ref }}/metrics.json \ | |
| ./results/${{ github.event.pull_request.merge_commit_sha }}/metrics.json \ | |
| ../comparison.md | |
| - name: Upload artifacts | |
| if: always() | |
| continue-on-error: true | |
| uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | |
| with: | |
| name: benchmark-results | |
| path: | | |
| ./valkey-perf-benchmark/results/${{ github.event.pull_request.merge_commit_sha }}/metrics.json | |
| ./valkey-perf-benchmark/results/${{ github.event.pull_request.base.ref }}/metrics.json | |
| comparison.md | |
| - name: Comment PR with results | |
| uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 | |
| with: | |
| github-token: ${{ secrets.GITHUB_TOKEN }} | |
| script: | | |
| const fs = require('fs'); | |
| const body = fs.readFileSync('comparison.md', 'utf8'); | |
| const {owner, repo} = context.repo; | |
| const sha = '${{ github.event.pull_request.head.sha }}'; | |
| const short = sha.slice(0,7); | |
| const link = `[\`${short}\`](https://github.com/${owner}/${repo}/commit/${sha})` | |
| await github.rest.issues.createComment({ | |
| issue_number: context.issue.number, | |
| owner, | |
| repo, | |
| body: `**Benchmark ran on this commit:** ${link}\n\n${body}` | |
| }); | |
| - name: Cleanup any running valkey processes | |
| if: always() | |
| continue-on-error: true | |
| run: | | |
| pkill -f valkey | |
| exit_code=$? | |
| if [ $exit_code -eq 0 ]; then | |
| echo "✓ Killed running valkey processes" | |
| elif [ $exit_code -eq 1 ]; then | |
| echo "No valkey processes found to kill" | |
| else | |
| echo "Warning: pkill failed with exit code $exit_code" | |
| fi | |
| - name: Remove ${{ github.event.label.name }} label | |
| if: always() && github.event.label.name == 'run-benchmark' | |
| uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8 | |
| with: | |
| github-token: ${{ secrets.GITHUB_TOKEN }} | |
| script: | | |
| await github.rest.issues.removeLabel({ | |
| issue_number: context.issue.number, | |
| owner: context.repo.owner, | |
| repo: context.repo.repo, | |
| name: '${{ github.event.label.name }}' | |
| }).catch(err => console.log('label not present', err.message)); |