v0.16.3 #315
Replies: 1 comment
-
|
This was a major refactor to prep for several new contributions. @irishpadres - I refactored your "all leagues" code to fit into a structure that will work well with non-ESPN APIs. I moved most of your code into async_fetch_espn_all_leagues_data() which does the API calls w/ the tightened date ranges and moved the population of the league_name to process_event() which handles the parsing and attribute values. All the regression tests passed so I think we are OK. Lmk if there is an edge case that broke or feel free to fix yourself. @iAmWayward - The bad news is I cleaned up the DataCoordinator and I doubt your current PR merges cleanly. The good news, I refactored the code to make it very easy to integrate non-ESPN APIs using your approach. It should be easy to call your code from async_call_sport_apis() and get it working quickly. The improvements to the testing should make it easy to add tests for your new API. Using snapshots and mocks now instead of the old file overrides. @duczz - This version will not save Thanks to all of you for your contributions and patience as I did some long needed clean-up to make sure there was a solid base to build upon. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
last_updateto Recorder to slow growth (thanks @duczz for the idea)This was a major refactor of key components of the sensor in preparation for the addition of new functionality.
Please report any defects to the Issues log.
This discussion was created from the release v0.16.3.
Beta Was this translation helpful? Give feedback.
All reactions