[BUG] Eslint throwing error with tsx

[vatsalsinghkv]

Description

main.tsx is showing eslint errors.

Screenshots

✨ Browser

Brave

Checklist 🚀

• I checked and didn't find similar issue
• I have read the Contributing Guidelines
• I am willing to work on this issue (blank for no).

[gandholi-kumar]

Hi @vatsalsinghkv
I would like to work on this issue. Could you kindly assign it to me?

Query:
Do we need the "!" mark ?

[fekete965]

Hi @vatsalsinghkv I would like to work on this issue. Could you kindly assign it to me?

Query: Do we need the "!" mark ?

Technically it is "safe" to use non-null assertion in this scenario, but in my opinion, we should throw an error with a meaningful message if the HTML node is missing

[DhairyaMajmudar]

@vatsalsinghkv I would like to work on this issue. Can you pls. Assign this issue to me. My approach will be doing rew. Changes in the config files and main.tsx file

[vatsalsinghkv]

Hi @vatsalsinghkv I would like to work on this issue. Could you kindly assign it to me?

Query: Do we need the "!" mark ?

I've used ! assuming #root will exist in DOM this will throw an unhandled error if it couldn't find #div. If I remove! then I have to write a fallback code for the case what if #root doesn't exists in the DOM, which doesn't make sense as we are using react there must be #root

[gandholi-kumar]

Hi @vatsalsinghkv
Due to some unavoidable reasons, I'm not able to work on this task, can you kindly assign it to @DhairyaMajmudar.
Sorry for the inconvenience.

[fekete965]

@vatsalsinghkv I would like to work on this issue. Can you pls. Assign this issue to me. My approach will be doing rew. Changes in the config files and main.tsx file

I don't think we should change the eslint to allow this feature. It is better to avoid using non-null assertion.

[vatsalsinghkv]

@fekete965 actually null assertion for root element is kinda standard, basically we need to add tslint

[fekete965]

@fekete965 actually null assertion for root element is kinda standard, basically we need to add tslint

You cannot be 100% sure the root element is there IMO. You don't create your root element but rely on a static HTML file which can be tinkered with. It would be nicer to throw an error to the console instead of letting the application crash.

TSlint is deprecated, it shouldn't be used, typescript-eslint should be added instead.

[VibhorShukla-BHRT]

@vatsalsinghkv let me fix this, please assign this issue to me, i will submit a pr within 30 mins 🔥