test: Adjust test names to valid_after/to semantics

To make the API usage explicit.

Author: jhf

expected/21_init.out

@@ -1,4 +1,4 @@
-INSERT INTO shifts(job_id, worker_id, valid_from, valid_to) VALUES
+INSERT INTO shifts(job_id, worker_id, valid_after, valid_to) VALUES
   (1, 1, '2017-11-27 06:00:00', '2017-11-27 12:00:00'),
   (1, 2, '2017-11-27 12:00:00', '2017-11-27 17:00:00'),
   (2, 3, '2017-11-27 06:00:00', '2017-11-27 12:00:00'),
@@ -10,7 +10,7 @@ INSERT INTO shifts(job_id, worker_id, valid_from, valid_to) VALUES
 ;
 -- TRUE:
 -- it covers when the range matches one exactly:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 12:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 12:00:00'))
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -19,7 +19,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- it covers when the range matches two exactly:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 17:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 17:00:00'))
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -28,7 +28,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- it covers when the range has extra in front:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 08:00:00', '2017-11-27 17:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 08:00:00', '2017-11-27 17:00:00'))
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -37,7 +37,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- it covers when the range has extra behind:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 14:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 14:00:00'))
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -46,7 +46,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- it covers when the range has extra on both sides:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 08:00:00', '2017-11-27 14:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 08:00:00', '2017-11-27 14:00:00'))
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -55,7 +55,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- an infinite start will cover a finite target:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 17:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 17:00:00'))
 FROM    shifts
 WHERE   job_id = 3;
  no_gaps 
@@ -64,7 +64,7 @@ WHERE   job_id = 3;
 (1 row)
 
 -- an infinite start will cover an infinite target:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('-infinity', '2017-11-27 17:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('-infinity', '2017-11-27 17:00:00'))
 FROM    shifts
 WHERE   job_id = 3;
  no_gaps 
@@ -73,7 +73,7 @@ WHERE   job_id = 3;
 (1 row)
 
 -- an infinite end will cover a finite target:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 17:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 17:00:00'))
 FROM    shifts
 WHERE   job_id = 4;
  no_gaps 
@@ -82,7 +82,7 @@ WHERE   job_id = 4;
 (1 row)
 
 -- an infinite end will cover an infinite target:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 06:00:00', 'infinity'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 06:00:00', 'infinity'))
 FROM    shifts
 WHERE   job_id = 4;
  no_gaps 
@@ -101,7 +101,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- it does not cover when the range misses completely:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-29 08:00:00', '2017-11-29 14:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-29 08:00:00', '2017-11-29 14:00:00'))
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -110,7 +110,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- it does not cover when the range has something at the beginning:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 04:00:00', '2017-11-27 14:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 04:00:00', '2017-11-27 14:00:00'))
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -119,7 +119,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- it does not cover when the range has something at the end:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 20:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 20:00:00'))
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -128,7 +128,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- it does not cover when the range has something in the middle:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 17:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 17:00:00'))
 FROM    shifts
 WHERE   job_id = 2;
  no_gaps 
@@ -137,7 +137,7 @@ WHERE   job_id = 2;
 (1 row)
 
 -- it does not cover when the range is lower-unbounded:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('-infinity', '2017-11-27 17:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('-infinity', '2017-11-27 17:00:00'))
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -146,7 +146,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- it does not cover when the range is upper-unbounded:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 06:00:00', 'infinity'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 06:00:00', 'infinity'))
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -155,7 +155,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- it does not cover when the range is both-sides-unbounded:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('-infinity', 'infinity'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('-infinity', 'infinity'))
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -164,7 +164,7 @@ WHERE   job_id = 1;
 (1 row)
 
 -- an infinite start will not cover a finite target if there is uncovered time at the end:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 20:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 06:00:00', '2017-11-27 20:00:00'))
 FROM    shifts
 WHERE   job_id = 3;
  no_gaps 
@@ -173,7 +173,7 @@ WHERE   job_id = 3;
 (1 row)
 
 -- an infinite start will not cover an infinite target if there is uncovered time at the end:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('-infinity', '2017-11-27 20:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('-infinity', '2017-11-27 20:00:00'))
 FROM    shifts
 WHERE   job_id = 3;
  no_gaps 
@@ -182,7 +182,7 @@ WHERE   job_id = 3;
 (1 row)
 
 -- an infinite end will not cover a finite target if there is uncovered time at the beginning:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 03:00:00', '2017-11-27 17:00:00'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 03:00:00', '2017-11-27 17:00:00'))
 FROM    shifts
 WHERE   job_id = 4;
  no_gaps 
@@ -191,7 +191,7 @@ WHERE   job_id = 4;
 (1 row)
 
 -- an infinite end will not cover an infinite target if there is uncovered time at the beginning:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 03:00:00', 'infinity'))
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 03:00:00', 'infinity'))
 FROM    shifts
 WHERE   job_id = 4;
  no_gaps 
@@ -201,7 +201,7 @@ WHERE   job_id = 4;
 
 -- NULL:
 -- it is unknown when the target is null:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), null)
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), null)
 FROM    shifts
 WHERE   job_id = 1;
  no_gaps 
@@ -211,10 +211,10 @@ WHERE   job_id = 1;
 
 -- Errors:
 -- it fails if the input ranges go backwards:
-SELECT  sql_saga.no_gaps(tstzrange(valid_from,valid_to), tstzrange('2017-11-27 13:00:00', '2017-11-27 20:00:00') ORDER BY worker_id DESC)
+SELECT  sql_saga.no_gaps(tstzrange(valid_after,valid_to), tstzrange('2017-11-27 13:00:00', '2017-11-27 20:00:00') ORDER BY worker_id DESC)
 FROM    shifts
 WHERE   job_id = 1;
 ERROR:  no_gaps first argument should be sorted but got a range ending before the last covered_to
--- TODO: handle an empty target range? e.g. [5, 5)
+-- TODO: handle an empty target range? e.g. (5, 5]
 -- Or maybe since that is a self-contradiction maybe ignore that case?
 DELETE FROM shifts;

expected/22_no_gaps_test.out

@@ -16,7 +16,7 @@ SELECT disable_sql_saga_for_shifts_houses_and_rooms();
 (1 row)
 
 -- it works on a table with a NULL foreign key
-INSERT INTO rooms(id,house_id,valid_from,valid_to) VALUES (1, NULL, '2015-01-01'::TIMESTAMPTZ, '2017-01-01'::TIMESTAMPTZ);
+INSERT INTO rooms(id,house_id,valid_after,valid_to) VALUES (1, NULL, '2015-01-01'::TIMESTAMPTZ, '2017-01-01'::TIMESTAMPTZ);
 SELECT enable_sql_saga_for_shifts_houses_and_rooms();
  enable_sql_saga_for_shifts_houses_and_rooms 
 ---------------------------------------------
@@ -31,7 +31,7 @@ SELECT disable_sql_saga_for_shifts_houses_and_rooms();
 
 DELETE FROM rooms;
 -- it works on a table with a FK fulfilled by one row
-INSERT INTO rooms(id,house_id,valid_from,valid_to) VALUES (1, 1, '2015-01-01'::TIMESTAMPTZ, '2016-01-01'::TIMESTAMPTZ);
+INSERT INTO rooms(id,house_id,valid_after,valid_to) VALUES (1, 1, '2015-01-01'::TIMESTAMPTZ, '2016-01-01'::TIMESTAMPTZ);
 SELECT enable_sql_saga_for_shifts_houses_and_rooms();
  enable_sql_saga_for_shifts_houses_and_rooms 
 ---------------------------------------------
@@ -46,7 +46,7 @@ SELECT disable_sql_saga_for_shifts_houses_and_rooms();
 
 DELETE FROM rooms;
 -- it works on a table with a FK fulfilled by two rows
-INSERT INTO rooms(id,house_id,valid_from,valid_to) VALUES (1, 1, '2015-01-01'::TIMESTAMPTZ, '2016-06-01'::TIMESTAMPTZ);
+INSERT INTO rooms(id,house_id,valid_after,valid_to) VALUES (1, 1, '2015-01-01'::TIMESTAMPTZ, '2016-06-01'::TIMESTAMPTZ);
 SELECT enable_sql_saga_for_shifts_houses_and_rooms();
  enable_sql_saga_for_shifts_houses_and_rooms 
 ---------------------------------------------
@@ -61,7 +61,7 @@ SELECT disable_sql_saga_for_shifts_houses_and_rooms();
 
 DELETE FROM rooms;
 -- it fails on a table with a missing foreign key
-INSERT INTO rooms(id,house_id,valid_from,valid_to) VALUES (1, 2, '2015-01-01'::TIMESTAMPTZ, '2016-01-01'::TIMESTAMPTZ);
+INSERT INTO rooms(id,house_id,valid_after,valid_to) VALUES (1, 2, '2015-01-01'::TIMESTAMPTZ, '2016-01-01'::TIMESTAMPTZ);
 SELECT enable_sql_saga_for_shifts_houses_and_rooms();
 ERROR:  insert or update on table "rooms" violates foreign key constraint "rooms_house_id_valid"
 CONTEXT:  PL/pgSQL function sql_saga.validate_foreign_key_new_row(name,jsonb) line 133 at RAISE
@@ -77,7 +77,7 @@ SELECT disable_sql_saga_for_shifts_houses_and_rooms();
 
 DELETE FROM rooms;
 -- it fails on a table with a completely-uncovered foreign key
-INSERT INTO rooms(id,house_id,valid_from,valid_to) VALUES (1, 1, '2010-01-01'::TIMESTAMPTZ, '2011-01-01'::TIMESTAMPTZ);
+INSERT INTO rooms(id,house_id,valid_after,valid_to) VALUES (1, 1, '2010-01-01'::TIMESTAMPTZ, '2011-01-01'::TIMESTAMPTZ);
 SELECT enable_sql_saga_for_shifts_houses_and_rooms();
 ERROR:  insert or update on table "rooms" violates foreign key constraint "rooms_house_id_valid"
 CONTEXT:  PL/pgSQL function sql_saga.validate_foreign_key_new_row(name,jsonb) line 133 at RAISE
@@ -93,7 +93,7 @@ SELECT disable_sql_saga_for_shifts_houses_and_rooms();
 
 DELETE FROM rooms;
 -- it fails on a table with a partially-covered foreign key
-INSERT INTO rooms(id,house_id,valid_from,valid_to) VALUES (1, 1, '2015-01-01'::TIMESTAMPTZ, '2018-01-01'::TIMESTAMPTZ);
+INSERT INTO rooms(id,house_id,valid_after,valid_to) VALUES (1, 1, '2015-01-01'::TIMESTAMPTZ, '2018-01-01'::TIMESTAMPTZ);
 SELECT enable_sql_saga_for_shifts_houses_and_rooms();
 ERROR:  insert or update on table "rooms" violates foreign key constraint "rooms_house_id_valid"
 CONTEXT:  PL/pgSQL function sql_saga.validate_foreign_key_new_row(name,jsonb) line 133 at RAISE

expected/23_create_temporal_foreign_key_test.out

@@ -15,57 +15,57 @@ INSERT INTO houses VALUES
 DELETE FROM houses WHERE id = 2;
 -- You can delete a finite pk range with no references
 INSERT INTO rooms VALUES (1, 1, '2016-06-01'::TIMESTAMPTZ, '2017-01-01'::TIMESTAMPTZ);
-DELETE FROM houses WHERE id = 1 and tstzrange(valid_from, valid_to) @> '2015-06-01'::timestamptz;
+DELETE FROM houses WHERE id = 1 and tstzrange(valid_after, valid_to) @> '2015-06-01'::timestamptz;
 INSERT INTO houses VALUES (1, 200000, '2015-01-01'::TIMESTAMPTZ, '2016-01-01'::TIMESTAMPTZ);
 DELETE FROM rooms;
 -- You can't delete a finite pk range that is partly covered
 INSERT INTO rooms VALUES (1, 1, '2016-01-01'::TIMESTAMPTZ, '2016-06-01'::TIMESTAMPTZ);
-DELETE FROM houses WHERE id = 1 and tstzrange(valid_from, valid_to) @> '2016-06-01'::timestamptz;
+DELETE FROM houses WHERE id = 1 and tstzrange(valid_after, valid_to) @> '2016-06-01'::timestamptz;
 ERROR:  update or delete on table "houses" violates foreign key constraint "rooms_house_id_valid" on table "rooms"
 CONTEXT:  PL/pgSQL function sql_saga.validate_foreign_key_old_row(name,jsonb,boolean) line 163 at RAISE
 SQL statement "SELECT sql_saga.validate_foreign_key_old_row(TG_ARGV[0], jold, false)"
 PL/pgSQL function sql_saga.uk_delete_check() line 22 at PERFORM
 DELETE FROM rooms;
 -- You can't delete a finite pk range that is exactly covered
 INSERT INTO rooms VALUES (1, 1, '2016-01-01'::TIMESTAMPTZ, '2017-01-01'::TIMESTAMPTZ);
-DELETE FROM houses WHERE id = 1 and tstzrange(valid_from, valid_to) @> '2016-06-01'::timestamptz;
+DELETE FROM houses WHERE id = 1 and tstzrange(valid_after, valid_to) @> '2016-06-01'::timestamptz;
 ERROR:  update or delete on table "houses" violates foreign key constraint "rooms_house_id_valid" on table "rooms"
 CONTEXT:  PL/pgSQL function sql_saga.validate_foreign_key_old_row(name,jsonb,boolean) line 163 at RAISE
 SQL statement "SELECT sql_saga.validate_foreign_key_old_row(TG_ARGV[0], jold, false)"
 PL/pgSQL function sql_saga.uk_delete_check() line 22 at PERFORM
 DELETE FROM rooms;
 -- You can't delete a finite pk range that is more than covered
 INSERT INTO rooms VALUES (1, 1, '2015-06-01'::TIMESTAMPTZ, '2017-01-01'::TIMESTAMPTZ);
-DELETE FROM houses WHERE id = 1 and tstzrange(valid_from, valid_to) @> '2016-06-01'::timestamptz;
+DELETE FROM houses WHERE id = 1 and tstzrange(valid_after, valid_to) @> '2016-06-01'::timestamptz;
 ERROR:  update or delete on table "houses" violates foreign key constraint "rooms_house_id_valid" on table "rooms"
 CONTEXT:  PL/pgSQL function sql_saga.validate_foreign_key_old_row(name,jsonb,boolean) line 163 at RAISE
 SQL statement "SELECT sql_saga.validate_foreign_key_old_row(TG_ARGV[0], jold, false)"
 PL/pgSQL function sql_saga.uk_delete_check() line 22 at PERFORM
 DELETE FROM rooms;
 -- You can delete an infinite pk range with no references
 INSERT INTO rooms VALUES (1, 3, '2014-06-01'::TIMESTAMPTZ, '2015-01-01'::TIMESTAMPTZ);
-DELETE FROM houses WHERE id = 3 and tstzrange(valid_from, valid_to) @> '2016-01-01'::timestamptz;
+DELETE FROM houses WHERE id = 3 and tstzrange(valid_after, valid_to) @> '2016-01-01'::timestamptz;
 INSERT INTO houses VALUES (3, 200000, '2015-01-01'::TIMESTAMPTZ, 'infinity');
 DELETE FROM rooms;
 -- You can't delete an infinite pk range that is partly covered
 INSERT INTO rooms VALUES (1, 3, '2016-01-01'::TIMESTAMPTZ, '2017-01-01'::TIMESTAMPTZ);
-DELETE FROM houses WHERE id = 3 and tstzrange(valid_from, valid_to) @> '2016-01-01'::timestamptz;
+DELETE FROM houses WHERE id = 3 and tstzrange(valid_after, valid_to) @> '2016-01-01'::timestamptz;
 ERROR:  update or delete on table "houses" violates foreign key constraint "rooms_house_id_valid" on table "rooms"
 CONTEXT:  PL/pgSQL function sql_saga.validate_foreign_key_old_row(name,jsonb,boolean) line 163 at RAISE
 SQL statement "SELECT sql_saga.validate_foreign_key_old_row(TG_ARGV[0], jold, false)"
 PL/pgSQL function sql_saga.uk_delete_check() line 22 at PERFORM
 DELETE FROM rooms;
 -- You can't delete an infinite pk range that is exactly covered
 INSERT INTO rooms VALUES (1, 3, '2015-01-01'::TIMESTAMPTZ, 'infinity');
-DELETE FROM houses WHERE id = 3 and tstzrange(valid_from, valid_to) @> '2016-01-01'::timestamptz;
+DELETE FROM houses WHERE id = 3 and tstzrange(valid_after, valid_to) @> '2016-01-01'::timestamptz;
 ERROR:  update or delete on table "houses" violates foreign key constraint "rooms_house_id_valid" on table "rooms"
 CONTEXT:  PL/pgSQL function sql_saga.validate_foreign_key_old_row(name,jsonb,boolean) line 163 at RAISE
 SQL statement "SELECT sql_saga.validate_foreign_key_old_row(TG_ARGV[0], jold, false)"
 PL/pgSQL function sql_saga.uk_delete_check() line 22 at PERFORM
 DELETE FROM rooms;
 -- You can't delete an infinite pk range that is more than covered
 INSERT INTO rooms VALUES (1, 3, '2014-06-01'::TIMESTAMPTZ, 'infinity');
-DELETE FROM houses WHERE id = 3 and tstzrange(valid_from, valid_to) @> '2016-01-01'::timestamptz;
+DELETE FROM houses WHERE id = 3 and tstzrange(valid_after, valid_to) @> '2016-01-01'::timestamptz;
 ERROR:  update or delete on table "houses" violates foreign key constraint "rooms_house_id_valid" on table "rooms"
 CONTEXT:  PL/pgSQL function sql_saga.validate_foreign_key_old_row(name,jsonb,boolean) line 163 at RAISE
 SQL statement "SELECT sql_saga.validate_foreign_key_old_row(TG_ARGV[0], jold, false)"