Skip to content

Commit e1f5ba8

Browse files
authored
Follow up to "Update colors to be non-hardcoded" (#48)
* forgot to include when removing hardcoded colors * change log complete * remove custom colors * minor tweaks
1 parent ea60a5f commit e1f5ba8

File tree

5 files changed

+6
-16
lines changed

5 files changed

+6
-16
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
## 0.0.17
2+
- Follow up to "Update colors to be non-hardcoded" by @jckras in https://github.com/viamrobotics/viam_flutter_hotspot_provisioning_widget/pull/48
13
## 0.0.16
24
- Update colors to be non-hardcoded by @jckras in https://github.com/viamrobotics/viam_flutter_hotspot_provisioning_widget/pull/46
35
- [APP-9720] [Hotspot prov widget] remove the "done" button on the setting up device screen by @jckras in https://github.com/viamrobotics/viam_flutter_hotspot_provisioning_widget/pull/44

lib/src/screens/network_selection.dart/widgets/network_selection_screen.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class _NetworkSelectionScreenState extends State<NetworkSelectionScreen> {
4343
}
4444
if (widget.viewModel.machineVisibleNetworks.isEmpty) {
4545
return NoContentWidget(
46-
icon: Icon(Icons.error, color: Theme.of(context).colorScheme.error),
46+
icon: Icon(Icons.error, color: Theme.of(context).colorScheme.error),
4747
buttons: [
4848
FilledButton(
4949
onPressed: () {
@@ -126,7 +126,6 @@ class _NetworkSelectionScreenState extends State<NetworkSelectionScreen> {
126126
child: Center(
127127
child: ElevatedButton(
128128
style: ElevatedButton.styleFrom(
129-
backgroundColor: Theme.of(context).colorScheme.primary,
130129
shape: RoundedRectangleBorder(
131130
borderRadius: BorderRadius.circular(24.0),
132131
),
@@ -143,7 +142,6 @@ class _NetworkSelectionScreenState extends State<NetworkSelectionScreen> {
143142
},
144143
child: Text(
145144
"My network isn't showing up",
146-
style: TextStyle(color: Theme.of(context).colorScheme.onPrimary, fontWeight: FontWeight.w500),
147145
),
148146
),
149147
),

lib/src/screens/shared_widgets/pill_button.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ class PillButton extends StatelessWidget {
1919
return TextButton(
2020
style: ButtonStyle(
2121
shape: WidgetStatePropertyAll(RoundedRectangleBorder(borderRadius: BorderRadius.circular(20.0))),
22-
backgroundColor: WidgetStatePropertyAll(enabled == null || !enabled! ? Theme.of(context).disabledColor : Theme.of(context).colorScheme.primary),
2322
),
2423
onPressed: onPressed,
2524
child: Row(

lib/src/screens/shared_widgets/primary_button.dart

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,13 @@ class PrimaryButton extends StatelessWidget {
1616
Widget build(BuildContext context) {
1717
return FilledButton(
1818
onPressed: (isLoading || onPressed == null) ? null : onPressed,
19-
style: OutlinedButton.styleFrom(backgroundColor: Theme.of(context).colorScheme.primary),
2019
child: isLoading
2120
? SizedBox(
2221
width: 20,
2322
height: 20,
24-
child: CircularProgressIndicator.adaptive(
25-
backgroundColor: Theme.of(context).colorScheme.onPrimary,
26-
),
23+
child: CircularProgressIndicator.adaptive(),
2724
)
28-
: Text(
29-
text,
30-
style: TextStyle(
31-
fontWeight: FontWeight.w500,
32-
color: onPressed != null ? Theme.of(context).colorScheme.onPrimary : Theme.of(context).disabledColor,
33-
),
34-
),
25+
: Text(text),
3526
);
3627
}
3728
}

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: viam_flutter_hotspot_provisioning_widget
22
description: "A Viam Flutter Hotspot Provisioning Widget."
3-
version: 0.0.16
3+
version: 0.0.17
44
repository: https://github.com/viamrobotics/viam_flutter_hotspot_provisioning_widget
55
homepage: https://www.viam.com/
66

0 commit comments

Comments
 (0)