fix: handle non-dict types for overlapped_items in MultiHopSpecificQuerySynthesizer

- Updated logic to check if overlapped_items is a dictionary before extracting keys.
- Ensured compatibility with non-dict types for overlapped_items.

Author: alex-graber-pmi

ragas/src/ragas/testset/synthesizers/multi_hop/abstract.py

@@ -42,7 +42,9 @@ class MultiHopAbstractQuerySynthesizer(MultiHopQuerySynthesizer):
     def get_node_clusters(self, knowledge_graph: KnowledgeGraph) -> t.List[t.Set[Node]]:
         """Identify clusters of nodes based on the specified relationship condition."""
         node_clusters = knowledge_graph.find_indirect_clusters(
-            relationship_condition=lambda rel: bool(rel.get_property(self.relation_property)),
+            relationship_condition=lambda rel: bool(
+                rel.get_property(self.relation_property)
+            ),
             depth_limit=3,
         )
         logger.info("found %d clusters", len(node_clusters))
@@ -89,7 +91,9 @@ async def _generate_scenarios(
                     nodes.append(node)
 
             base_scenarios = []
-            node_themes = [node.properties.get(self.abstract_property_name, []) for node in nodes]
+            node_themes = [
+                node.properties.get(self.abstract_property_name, []) for node in nodes
+            ]
             prompt_input = ConceptsList(
                 lists_of_concepts=node_themes, max_combinations=num_sample_per_cluster
             )

ragas/src/ragas/testset/synthesizers/multi_hop/specific.py

@@ -2,6 +2,7 @@
 
 import logging
 import typing as t
+from collections.abc import Iterable
 from dataclasses import dataclass
 
 import numpy as np
@@ -81,7 +82,16 @@ async def _generate_scenarios(
                 overlapped_items = []
                 overlapped_items = triplet[1].properties[self.relation_overlap_property]
                 if overlapped_items:
-                    themes = list(dict(overlapped_items).keys())
+                    if not all(
+                        isinstance(item, (str, Iterable)) for item in overlapped_items
+                    ):
+                        logger.debug("Overlapped items are not strings or iterables.")
+                        continue
+                    themes = (
+                        list(overlapped_items.keys())
+                        if isinstance(overlapped_items, dict)
+                        else overlapped_items
+                    )
                     prompt_input = ThemesPersonasInput(
                         themes=themes, personas=persona_list
                     )
@@ -90,10 +100,13 @@ async def _generate_scenarios(
                             data=prompt_input, llm=self.llm, callbacks=callbacks
                         )
                     )
-                    overlapped_items = [list(item) for item in overlapped_items]
+                    combinations = [
+                        [item] if isinstance(item, str) else list(item)
+                        for item in themes
+                    ]
                     base_scenarios = self.prepare_combinations(
                         [node_a, node_b],
-                        overlapped_items,
+                        combinations,
                         personas=persona_list,
                         persona_item_mapping=persona_concepts.mapping,
                         property_name=self.property_name,

ragas/tests/unit/test_analytics.py

@@ -135,7 +135,7 @@ def test_testset_generation_tracking(monkeypatch):
     )
 
     assert testset_event_payload.model_dump()["evolution_names"] == [
-        "single_hop_specifc_query_synthesizer",
+        "single_hop_specific_query_synthesizer",
         "multi_hop_abstract_query_synthesizer",
         "multi_hop_specific_query_synthesizer",
     ]