open file api integration

[N7ghtm4r3]

Hi, can be possibile to integrate an open file api in the FileKit library? If it is a possible integration may I can work on it!

[N7ghtm4r3]

The main problem will be on the web target I think

[vinceglb]

What do you mean exactly by "open file api"?

Do you mean something like this?

val imageFile = FileKit.openCameraPicker()
imageFile.openFile()

And for example, on Android, it opens the image in the Google Photos / Gallery app of the phone?

[N7ghtm4r3]

Yes exactly! I mean something like that, but extended for all type of files

[N7ghtm4r3]

Hi, any updates about this possible integration?

[vinceglb]

I was thinking about something like:

commonMain/PlatformFile.kt

/**
 * Opens the file using the platform-specific method.
 * This is typically used to open files in their default application.
 */
public expect fun PlatformFile.openFile()

androidMain/PlatformFile.kt

public actual suspend fun PlatformFile.openFile() {
    when(androidFile) {
        is AndroidFile.FileWrapper -> {
            // TODO
        }
        is AndroidFile.UriWrapper -> {
            val intent = Intent(Intent.ACTION_VIEW).apply {
                data = androidFile.uri
                flags = Intent.FLAG_ACTIVITY_NEW_TASK or Intent.FLAG_GRANT_READ_URI_PERMISSION
            }
            FileKit.context.startActivity(intent)
        }
    }
}

This is not working great, but it's for the example.

And so on for all other targets...

And use like this:

val file = FileKit.openFilePicker()
file?.openFile() // it opens the file in the default app

It's possible to begin by focusing only non-web targets (android, iOS, macOS, and JVM) 👌

[N7ghtm4r3]

Yes exactly that! Good to know about the web target later integration. If for you is okay I can work on it for a first draft and then look for the web also, but I need a bit of time to start to work on and then to complete, do I have the time or you need to integrate fastly?

[N7ghtm4r3]

Hi, I can start to work on it, but I don't know if I can do the integration fastly and continuatively, I just wont to ask you if I need to create a dedicated branch or commit directly into main

[vinceglb]

No pressure!

You can take your time working on it when you want and publish a pull request later! It's already great that you can contribute on your free time 🙏 Like you've done, you can fork the repository, work on it like you want and submit the pull request when you're ready 👌

And if for some reason you cannot finish the feature, it's not a problem, just inform me if it's the case.

[N7ghtm4r3]

Hi, thank you! I really appreciate your support and trust. I will do my best to complete it

[N7ghtm4r3]

Just to warn you I needed to downgrade the agp version from 8.12.0-rc01 to 8.10.0 due my Android Studio version.
I hope this is not a problem, but I think will not a problem bump it again when you check the pull request

[vinceglb]

Yes no problem 👌

[N7ghtm4r3]

Hi, I'd like to share a report with you because I thought the integration would take longer, but I managed to integrate:

• JVM
• Android
• iOS - not tested because I can't run on iOS at the moment
• macOS - not tested because I can't run on macOS at the moment
  The web target is still missing, but it's more complex than the other targets and I think it will take longer. Can I ask if you can test it, especially on the iOS and macOS targets, so I can focus directly on the web? Let me know if you need to be invited to the forked repository or if you prefer a pull request. Thanks again for the opportunity!

[N7ghtm4r3]

Hi, thanks for the reply and your suggestion!
I will move the api in nonWeb target as you said, but I hope to find a way to implement also in the web using any workarounds if it is possible. My opinion related to move this api directly in FileKit is agree with you and I will move in it. Can I ask to you if you had the possibility to test the current implentation? Today I will apply the changes anyway!

[N7ghtm4r3]

Hi, I have applyed the changes discussed before! Do I need to open the pull request?

[vinceglb]

Super! Yes you can create a pull request, I'll test it out!

[N7ghtm4r3]

Hi, thank you! I am really happy

[N7ghtm4r3]

Just opened #352!