Skip to content

Commit 31a7ff5

Browse files
Merge pull request #160 from virtusize/fix/make-sns-buttons-show-by-default
Make sns buttons shown by default
2 parents b1dbcd8 + 4c796fb commit 31a7ff5

10 files changed

Lines changed: 22 additions & 21 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
- Fix: Fix user auth data storing
77
- Fix: Add loading animation for VirtusizeInPageViews
88
- Fix: Change inpage buttons text to be the same as in web version
9+
- Fix: Make sns buttons shown by default
910

1011
### 2.12.0
1112
- Feature: Update Flutter SDK implementation to be compatible with latest changes

README-COMPOSE.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ following table:
114114
| setShowSGI | Boolean | setShowSGI(true) | Determines whether the integration will fetch SGI and use SGI flow for users to add user generated items to their wardrobe. | No. By default, ShowSGI is set to false |
115115
| setAllowedLanguages | A list of `VirtusizeLanguage` | In Kotlin, setAllowedLanguages(mutableListOf(VirtusizeLanguage.EN, VirtusizeLanguage.JP))<br />In Java, setAllowedLanguages(Arrays.asList(VirtusizeLanguage.EN, VirtusizeLanguage.JP)) | The languages which the user can switch to using the Language Selector | No. By default, the integration allows all possible languages to be displayed, including English, Japanese and Korean. |
116116
| setDetailsPanelCards | A list of `VirtusizeInfoCategory` | In Kotlin, setDetailsPanelCards(mutableListOf(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT))<br />In Java, setDetailsPanelCards(Arrays.asList(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT)) | The info categories which will be display in the Product Details tab. Possible categories are: `VirtusizeInfoCategory.MODEL_INFO`, `VirtusizeInfoCategory.GENERAL_FIT`, `VirtusizeInfoCategory.BRAND_SIZING` and `VirtusizeInfoCategory.MATERIAL` | No. By default, the integration displays all the possible info categories in the Product Details tab. |
117-
| setShowSNSButtons | Boolean | setShowSNSButtons(true) | Determines whether the integration will show the SNS buttons to the users | No. By default, the integration disables the SNS buttons |
117+
| setShowSNSButtons | Boolean | setShowSNSButtons(true) | Determines whether the integration will show the SNS buttons to the users | No. By default, the integration enables the SNS buttons |
118118

119119
```kotlin
120120
override fun onCreate() {
@@ -136,8 +136,8 @@ override fun onCreate() {
136136
.setAllowedLanguages(listOf(VirtusizeLanguage.EN, VirtusizeLanguage.JP))
137137
// By default, Virtusize displays all the possible info categories in the Product Details tab
138138
.setDetailsPanelCards(setOf(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT))
139-
// By default, Virtusize disables the SNS buttons
140-
.setShowSNSButtons(false)
139+
// By default, Virtusize enables the SNS buttons
140+
.setShowSNSButtons(true)
141141
.build()
142142
}
143143
```

README-JP.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ Proguardをお使いの場合、Proguardのルールファイルに下記のル
113113
| setShowSGI | Boolean | setShowSGI(true) | ユーザーが生成したアイテムをワードローブに追加するために、SGIを取得してSGIフローを使用するかどうかを決定します。 | 特になし。デフォルトではShowSGIはfalseに設定されています。 |
114114
| setAllowedLanguages | `VirtusizeLanguage`列挙のリスト | In Kotlin, setAllowedLanguages(mutableListOf(VirtusizeLanguage.EN, VirtusizeLanguage.JP))<br />In Java, setAllowedLanguages(Arrays.asList(VirtusizeLanguage.EN, VirtusizeLanguage.JP)) | ユーザーが言語選択ボタンより選択できる言語 | 特になし。デフォルトでは、英語、日本語、韓国語など、表示可能なすべての言語が表示されるようになっています。 |
115115
| setDetailsPanelCards | `VirtusizeInfoCategory`列挙のリスト | In Kotlin, setDetailsPanelCards(mutableListOf(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT))<br />In Java, setDetailsPanelCards(Arrays.asList(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT)) | 商品詳細タブに表示する情報のカテゴリ。表示可能カテゴリは以下:`VirtusizeInfoCategory.MODELINFO`, `VirtusizeInfoCategory.GENERALFIT`, `VirtusizeInfoCategory.BRANDSIZING` および `VirtusizeInfoCategory.MATERIAL` | 特になし。デフォルトでは、商品詳細タブに表示可能なすべての情報カテゴリが表示されます。 |
116-
| setShowSNSButtons | Boolean | setShowSNSButtons(true) | Determines whether the integration will show the SNS buttons to the users | No. By default, the integration disables the SNS buttons |
116+
| setShowSNSButtons | Boolean | setShowSNSButtons(true) | Determines whether the integration will show the SNS buttons to the users | No. By default, the integration enables the SNS buttons |
117117

118118
```kotlin
119119
override fun onCreate() {
@@ -135,8 +135,8 @@ override fun onCreate() {
135135
.setAllowedLanguages(listOf(VirtusizeLanguage.EN, VirtusizeLanguage.JP))
136136
// デフォルトでは、商品詳細タブにすべての情報カテゴリが表示される
137137
.setDetailsPanelCards(setOf(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT))
138-
// デフォルトでは、SNS ボタンは非表示
139-
.setShowSNSButtons(false)
138+
// デフォルトでは、SNS ボタンが表示されます
139+
.setShowSNSButtons(true)
140140
.build()
141141
}
142142
```

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ following table:
121121
| setShowSGI | Boolean | setShowSGI(true) | Determines whether the integration will fetch SGI and use SGI flow for users to add user generated items to their wardrobe. | No. By default, ShowSGI is set to false |
122122
| setAllowedLanguages | A list of `VirtusizeLanguage` | In Kotlin, setAllowedLanguages(mutableListOf(VirtusizeLanguage.EN, VirtusizeLanguage.JP))<br />In Java, setAllowedLanguages(Arrays.asList(VirtusizeLanguage.EN, VirtusizeLanguage.JP)) | The languages which the user can switch to using the Language Selector | No. By default, the integration allows all possible languages to be displayed, including English, Japanese and Korean. |
123123
| setDetailsPanelCards | A list of `VirtusizeInfoCategory` | In Kotlin, setDetailsPanelCards(mutableListOf(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT))<br />In Java, setDetailsPanelCards(Arrays.asList(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT)) | The info categories which will be display in the Product Details tab. Possible categories are: `VirtusizeInfoCategory.MODEL_INFO`, `VirtusizeInfoCategory.GENERAL_FIT`, `VirtusizeInfoCategory.BRAND_SIZING` and `VirtusizeInfoCategory.MATERIAL` | No. By default, the integration displays all the possible info categories in the Product Details tab. |
124-
| setShowSNSButtons | Boolean | setShowSNSButtons(true) | Determines whether the integration will show the SNS buttons to the users | No. By default, the integration disables the SNS buttons |
124+
| setShowSNSButtons | Boolean | setShowSNSButtons(true) | Determines whether the integration will show the SNS buttons to the users | No. By default, the integration enables the SNS buttons |
125125
| setBranch | String | setBranch("branch-name") | Targets specific environment branch | No. By default, production environment is targeted. `staging` targets staging environment. `<branch-name>` targets a specific branch |
126126

127127
- Kotlin
@@ -146,8 +146,8 @@ following table:
146146
.setAllowedLanguages(listOf(VirtusizeLanguage.EN, VirtusizeLanguage.JP))
147147
// By default, Virtusize displays all the possible info categories in the Product Details tab
148148
.setDetailsPanelCards(setOf(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT))
149-
// By default, Virtusize disables the SNS buttons
150-
.setShowSNSButtons(false)
149+
// By default, Virtusize enables the SNS buttons
150+
.setShowSNSButtons(true)
151151
// Target the specific branch environment by its name
152152
.setBranch("branch-name")
153153
.build()
@@ -179,8 +179,8 @@ following table:
179179
.setAllowedLanguages(Arrays.asList(VirtusizeLanguage.EN, VirtusizeLanguage.JP))
180180
// By default, Virtusize displays all the possible info categories in the Product Details tab
181181
.setDetailsPanelCards(Set.of(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT))
182-
// By default, Virtusize disables the SNS buttons
183-
.setShowSNSButtons(false)
182+
// By default, Virtusize enables the SNS buttons
183+
.setShowSNSButtons(true)
184184
// Target the specific environment branch by its name
185185
.setBranch("branch-name")
186186
.build();

sampleAppKotlin/src/main/java/com/virtusize/sampleappkotlin/App.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class App : Application() {
2626
.setAllowedLanguages(listOf(VirtusizeLanguage.EN, VirtusizeLanguage.JP))
2727
// By default, Virtusize displays all the possible info categories in the Product Details tab
2828
.setDetailsPanelCards(setOf(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT))
29-
// By default, Virtusize disables the SNS buttons
29+
// By default, Virtusize enables the SNS buttons
3030
.setShowSNSButtons(true)
3131
// By default, branch is empty and `production` is used
3232
// .setBranch("branch-name")

sampleappcompose/src/main/java/com/virtusize/sampleapp/compose/VirtusizeSampleApplication.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ internal class VirtusizeSampleApplication : Application() {
2525
.setAllowedLanguages(listOf(VirtusizeLanguage.EN, VirtusizeLanguage.JP))
2626
// By default, Virtusize displays all the possible info categories in the Product Details tab
2727
.setDetailsPanelCards(setOf(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT))
28-
// By default, Virtusize disables the SNS buttons
29-
.setShowSNSButtons(false)
28+
// By default, Virtusize enables the SNS buttons
29+
.setShowSNSButtons(true)
3030
.build()
3131
}
3232
}

sampleappjava/src/main/java/com/virtusize/sampleappjava/App.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ public void onCreate() {
3535
.setAllowedLanguages(Arrays.asList(VirtusizeLanguage.EN, VirtusizeLanguage.JP))
3636
// By default, Virtusize displays all the possible info categories in the Product Details tab
3737
.setDetailsPanelCards(Set.of(VirtusizeInfoCategory.BRAND_SIZING, VirtusizeInfoCategory.GENERAL_FIT))
38-
// By default, Virtusize disables the SNS buttons
39-
.setShowSNSButtons(false)
38+
// By default, Virtusize enables the SNS buttons
39+
.setShowSNSButtons(true)
4040
.build();
4141
}
4242
}

virtusize/src/main/java/com/virtusize/android/VirtusizeBuilder.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class VirtusizeBuilder {
3535
VirtusizeLanguage.entries.toMutableList()
3636
private var showSGI: Boolean = false
3737
private var detailsPanelCards: Set<VirtusizeInfoCategory> = VirtusizeInfoCategory.entries.toMutableSet()
38-
private var showSNSButtons: Boolean = false
38+
private var showSNSButtons: Boolean = true
3939
private var branch: String? = null
4040

4141
/**
@@ -128,7 +128,7 @@ class VirtusizeBuilder {
128128

129129
/**
130130
* Sets up whether the Virtusize web app will show the SNS buttons
131-
* By default, showSNSButtons is false
131+
* By default, showSNSButtons is true
132132
* @param showSNSButtons the Boolean value
133133
* @return [VirtusizeBuilder]
134134
*/

virtusize/src/main/java/com/virtusize/android/flutter/VirtusizeFlutterBuilder.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class VirtusizeFlutterBuilder {
3535
VirtusizeLanguage.entries.toMutableList()
3636
private var showSGI: Boolean = false
3737
private var detailsPanelCards: Set<VirtusizeInfoCategory> = VirtusizeInfoCategory.entries.toMutableSet()
38-
private var showSNSButtons: Boolean = false
38+
private var showSNSButtons: Boolean = true
3939
private var branch: String? = null
4040
private var virtusizeFlutterPresenter: VirtusizeFlutterPresenter? = null
4141

@@ -129,7 +129,7 @@ class VirtusizeFlutterBuilder {
129129

130130
/**
131131
* Sets up whether the Virtusize web app will show the SNS buttons
132-
* By default, showSNSButtons is false
132+
* By default, showSNSButtons is true
133133
* @param showSNSButtons the Boolean value
134134
* @return [VirtusizeFlutterBuilder]
135135
*/

virtusize/src/main/java/com/virtusize/android/ui/VirtusizeWebViewFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import org.json.JSONObject
4343
class VirtusizeWebViewFragment : DialogFragment() {
4444
private var virtusizeWebAppUrl: String = VirtusizeApi.getVirtusizeWebViewURL()
4545

46-
private var showSNSButtons: Boolean = false
46+
private var showSNSButtons: Boolean = true
4747
private var vsParamsFromSDKScript = ""
4848
private var backButtonClickEventFromSDKScript =
4949
"javascript:vsEventFromSDK({ name: 'sdk-back-button-tapped'})"

0 commit comments

Comments
 (0)