Skip to content

Commit ecb88b4

Browse files
authored
Fix event handling in JS (#144)
1 parent 762b3b4 commit ecb88b4

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

jupyter_rfb/renderview-rfb.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -215,20 +215,20 @@ class AnywidgetRenderView extends BaseRenderView {
215215
if (event.type === 'resize') {
216216
// Note that there can be multiple views that can possibly be individually resized.
217217
// TODO: keep logical size in check between different views?
218-
if (event.width * event.height <= 0) {
219-
return // The element of a new view is temporarily zero-sized at initialization
218+
if (event.width * event.height > 0) {
219+
this.model.onEvent(event)
220220
}
221221
} else if (event.type === 'close') {
222-
return // we don't close when one view closes, only when the widget closes
222+
// we don't close when one view closes, only when the widget closes
223223
} else if (event.type === 'show') {
224224
this.isVisible = true
225225
this.model.updateVisibility()
226226
} else if (event.type === 'hide') {
227227
this.isVisible = false
228228
this.model.updateVisibility()
229+
} else {
230+
this.model.onEvent(event)
229231
}
230-
231-
this.model.onEvent(event)
232232
}
233233
}
234234

0 commit comments

Comments
 (0)