Skip to content

feat(vue-jsx): allow esbuild to perform ts transformation #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 25, 2025
Merged

feat(vue-jsx): allow esbuild to perform ts transformation #621

merged 12 commits into from
Aug 25, 2025

Conversation

madeofsun
Copy link
Contributor

@madeofsun madeofsun commented Jul 4, 2025 •
edited
Loading

Description

Additional context

In the original issue description the proposed new option tsTransform had values 'esbuild' and 'babel'. In the PR the 'esbuild' value was renamed to 'built-in' because it describes semantics more clearly and vite is planning to integrate rolldown as esbuild replacement.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@madeofsun madeofsun mentioned this pull request Jul 4, 2025
Closed
6 tasks
@sapphi-red sapphi-red added the p3-significant 🔨 High priority enhancement (priority) label Jul 7, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 7, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@621

npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@621

commit: 5bed74a

sapphi-red
sapphi-red reviewed Jul 7, 2025
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me. Would you

  • resolve the conflicts?
  • fix the lint error?

By the way, do you have any performance numbers for each transform? I'm wondering if the plugin should use tsTransform: 'built-in' in the future as that would align to how plugin-react works.

@madeofsun
Copy link
Contributor Author

madeofsun commented Jul 11, 2025 •
edited
Loading

Would you ...

No problem - done.

By the way, do you have any performance numbers ...

Simple comparisons of vite build output

For a "naive" approach in playground

Old
values: 1.90s 1.83s 1.80s 1.79s 1.81s 1.79s 1.79s 1.80s 1.81s 1.80s 1.81s 1.82s 1.89s 1.85s 1.81s 1.82s 1.92s 1.90s 1.81s 1.85s 1.82s 1.80s 1.84s 1.82s 1.79s
min: 1.79s
max: 1.92s
mid: 1.81s
avg: 1.827s

New
values: 1.80s 1.77s 1.77s 1.74s 1.74s 1.73s 1.75s 1.85s 1.74s 1.74s 1.85s 1.84s 1.80s 1.76s 1.80s 1.80s 1.85s 1.91s 1.83s 1.75s 1.83s 1.75s 1.78s 1.72s 1.82s
min: 1.72s
max: 1.91s
mid: 1.78s
avg: 1.789s

Old -> New -2%

For a real medium Nuxt project I have

  • 148 tsx files
  • 8928 modules total
Old
values: 14.3s 14.0s 14.1s 13.8s 14.0s
min: 13.8s
max: 14.3s
mid: 14.0s
avg: 14.04s

New
values: 13.7s 13.5s 13.6s 13.8s 13.6s
min: 13.5s
max: 13.8s
mid: 13.6s
avg: 13.64s

Old -> New -2.8%

For a real very large Nuxt project I have

  • 1287 tsx files
  • 13221 modules total
Old
values: 68s 65s 57s 65s 57s 68s 64s 62s
min: 57s
max: 68s
mid: 64.5s
avg: 63.25s

New
values: 74s 66s 69s 68s 65s 66s 66s 64s
min: 64s
max: 74s
mid: 66s
avg: 67.25

Old -> New +6.3%

@sapphi-red
Copy link
Member

Thanks for the perf numbers. It sounds like it's good enough to switch to it in the future to me.

@madeofsun
Copy link
Contributor Author

Thanks!

@sapphi-red sapphi-red linked an issue Aug 25, 2025 that may be closed by this pull request
plugin-vue-jsx: Allow esbuild to perform typescript transformation #556
Closed
6 tasks
@sapphi-red sapphi-red merged commit c453513 into vitejs:main Aug 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p3-significant 🔨 High priority enhancement (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin-vue-jsx: Allow esbuild to perform typescript transformation
2 participants
@madeofsun @sapphi-red