[Tests] GPTQ Actorder Resolution Tests #1468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
shanjiaz
approved these changes
May 29, 2025
Collaborator
shanjiaz
left a comment
shanjiaz
left a comment
There was a problem hiding this comment.
Looks great! Would appreciate if you could add a short docstring explaining what the test is about 🫡
aireilly
pushed a commit
to aireilly/llm-compressor
that referenced
this pull request
Jul 30, 2025
## Purpose ## * Clarify behavior introduced by vllm-project#1453 ## Changes ## * Remove `TestQuantizationRegistered` test, which is less necessary that it was before * Add `test_actorder_resolution`, which demonstrates and regression tests behavior related to resolving the `actorder` argument --------- Signed-off-by: Kyle Sayers <[email protected]> Co-authored-by: Dipika Sikka <[email protected]>
dsikka
added a commit
that referenced
this pull request
Sep 11, 2025
## Purpose ## * Use best defaults for GPTQ quantization ## Prerequisites ## * #1453 * #1468 ## Changes ## * Set gptq actorder default to "static" ## Testing ## * Ran llama w4a16 example to completion and validated the correct activation ordering --------- Signed-off-by: Kyle Sayers <[email protected]> Co-authored-by: Dipika Sikka <[email protected]>
dsikka
added a commit
that referenced
this pull request
Sep 21, 2025
## Purpose ## * Use best defaults for GPTQ quantization ## Prerequisites ## * #1453 * #1468 ## Changes ## * Set gptq actorder default to "static" ## Testing ## * Ran llama w4a16 example to completion and validated the correct activation ordering --------- Signed-off-by: Kyle Sayers <[email protected]> Co-authored-by: Dipika Sikka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
TestQuantizationRegisteredtest, which is less necessary that it was beforetest_actorder_resolution, which demonstrates and regression tests behavior related to resolving theactorderargument