Skip to content

Commit 2bb73dc

Browse files
committed
values.schema.json does not contradict to examples from tutorials/assets
Signed-off-by: sh1ng <[email protected]>
1 parent 7b27283 commit 2bb73dc

File tree

1 file changed

+31
-19
lines changed

1 file changed

+31
-19
lines changed

helm/values.schema.json

Lines changed: 31 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"$schema": "http://json-schema.org/schema#",
2+
"$schema": "https://json-schema.org/draft/2020-12/schema",
33
"type": "object",
44
"properties": {
55
"servingEngineSpec": {
@@ -71,7 +71,7 @@
7171
"type": "string"
7272
},
7373
"requestGPU": {
74-
"type": "integer"
74+
"type": "number"
7575
},
7676
"requestGPUType": {
7777
"type": "string"
@@ -214,11 +214,24 @@
214214
},
215215
"value": {
216216
"type": "string"
217+
},
218+
"valueFrom": {
219+
"type": "object"
217220
}
218221
},
219-
"required": [
220-
"name",
221-
"value"
222+
"anyOf": [
223+
{
224+
"required": [
225+
"name",
226+
"value"
227+
]
228+
},
229+
{
230+
"required": [
231+
"name",
232+
"valueFrom"
233+
]
234+
}
222235
]
223236
}
224237
},
@@ -267,8 +280,7 @@
267280
"replicaCount",
268281
"requestCPU",
269282
"requestMemory",
270-
"requestGPU",
271-
"pvcStorage"
283+
"requestGPU"
272284
]
273285
}
274286
},
@@ -405,19 +417,19 @@
405417
"type": "integer"
406418
},
407419
"vllmApiKey": {
408-
"type": "object",
409-
"properties": {
410-
"secretName": {
411-
"type": "string"
412-
},
413-
"secretKey": {
414-
"type": "string"
415-
}
420+
"type": "object",
421+
"properties": {
422+
"secretName": {
423+
"type": "string"
416424
},
417-
"required": [
418-
"secretName",
419-
"secretKey"
420-
]
425+
"secretKey": {
426+
"type": "string"
427+
}
428+
},
429+
"required": [
430+
"secretName",
431+
"secretKey"
432+
]
421433
},
422434
"labels": {
423435
"type": "object",

0 commit comments

Comments
 (0)