From 02f32b9ce50b60c81fec79a8aee7156d4be3831e Mon Sep 17 00:00:00 2001 From: sh1ng Date: Tue, 13 May 2025 15:09:07 +0200 Subject: [PATCH 1/2] values.schema.json does not contradict to examples from tutorials/assets Signed-off-by: sh1ng --- helm/values.schema.json | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/helm/values.schema.json b/helm/values.schema.json index 14393dd77..f5141f967 100644 --- a/helm/values.schema.json +++ b/helm/values.schema.json @@ -83,7 +83,7 @@ "type": "string" }, "requestGPU": { - "type": "integer" + "type": "number" }, "requestGPUType": { "type": "string" @@ -229,11 +229,24 @@ }, "value": { "type": "string" + }, + "valueFrom": { + "type": "object" } }, - "required": [ - "name", - "value" + "anyOf": [ + { + "required": [ + "name", + "value" + ] + }, + { + "required": [ + "name", + "valueFrom" + ] + } ] } }, @@ -282,8 +295,7 @@ "replicaCount", "requestCPU", "requestMemory", - "requestGPU", - "pvcStorage" + "requestGPU" ] } }, From 771fab8aa9fb0e4f50a1542a8afc86761c9739f9 Mon Sep 17 00:00:00 2001 From: sh1ng Date: Fri, 27 Jun 2025 16:07:49 +0200 Subject: [PATCH 2/2] add strategy --- helm/values.schema.json | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/helm/values.schema.json b/helm/values.schema.json index f5141f967..0b6104959 100644 --- a/helm/values.schema.json +++ b/helm/values.schema.json @@ -16,6 +16,17 @@ } } }, + "strategy": { + "type": "object", + "properties": { + "type": { + "enum": [ + "RollingUpdate", + "Recreate" + ] + } + } + }, "vllmApiKey": { "oneOf": [ {