refine bf16 group gemm dispatch policy#177
Open
xinyu-intel wants to merge 1 commit intovllm-project:mainfrom
Open
refine bf16 group gemm dispatch policy#177xinyu-intel wants to merge 1 commit intovllm-project:mainfrom
xinyu-intel wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Xinyu Chen <xinyu1.chen@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refines the Xe2 bf16/FP16 grouped GEMM dispatch and kernel tiling to improve performance, especially for smaller per-expert M (and generally smaller-N workloads).
Changes:
- Updates the w16a16 (bf16/fp16) dispatch thresholds to use specialized policies for
A_avg_M <= 8/16/32. - Adjusts the default Xe2 GEMM policy base workgroup tile and subgroup layout (
WGTileandSGLayout) to new shapes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
csrc/xpu/grouped_gemm/xe_2/grouped_gemm_xe2_interface.hpp |
Refines w16a16 policy selection based on A_avg_M to better target small-M cases. |
csrc/xpu/grouped_gemm/xe_2/gemm_xe2_policy.hpp |
Changes default policy base tiling/subgroup layout, impacting the default w16a16 kernel configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Please test more shapes, not only for the qwen a3b model. |
Collaborator
Author
sure. I won't merge this before we claim no regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS ABOVE HAVE BEEN CONSIDERED.
Purpose
To refine the dispatch policy of bf16 group gemm. Especially for the cases M and N are small.
Test Plan
Script:
Test Result
the performance comparison on B60:
(Optional) Documentation Update
BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)