Checkstyle: ImportOrder and FileTabCharacter checks

Author: vojtechhabarta

README.md

@@ -201,5 +201,5 @@ Contributing
 ### Code formatting
 
 - use 4 spaces for indentation in Java files
-- sort java imports alphabetically, you can use wildcards
+- sort java imports alphabetically (including static imports), you can use wildcards
 - please do not reformat whole files in IDE

checkstyle.xml

@@ -0,0 +1,20 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+    "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
+    "http://checkstyle.sourceforge.net/dtds/configuration_1_3.dtd">
+
+<module name="Checker">
+    <property name="charset" value="UTF-8"/>
+    <property name="fileExtensions" value="java"/>
+
+    <module name="FileTabCharacter"/>
+
+    <module name="TreeWalker">
+
+        <module name="ImportOrder">
+            <property name="option" value="inflow"/>
+            <property name="sortStaticImportsAlphabetically" value="true"/>
+        </module>
+
+    </module>
+</module>

pom.xml

@@ -98,6 +98,15 @@
                 <artifactId>maven-javadoc-plugin</artifactId>
                 <version>3.0.0</version>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>3.0.0</version>
+                <configuration>
+                    <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                    <configLocation>../checkstyle.xml</configLocation>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-site-plugin</artifactId>

typescript-generator-core/pom.xml

@@ -173,6 +173,22 @@
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>check</id>
+                        <phase>verify</phase>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                        <configuration>
+                            <excludes>cz/habarta/typescript/generator/xmldoclet/*.java</excludes>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
         </plugins>
     </build>
 

typescript-generator-core/src/main/java/cz/habarta/typescript/generator/TypeProcessor.java

@@ -1,8 +1,8 @@
 
 package cz.habarta.typescript.generator;
 
-import cz.habarta.typescript.generator.compiler.SymbolTable;
 import cz.habarta.typescript.generator.compiler.Symbol;
+import cz.habarta.typescript.generator.compiler.SymbolTable;
 import java.lang.reflect.Type;
 import java.util.*;
 

typescript-generator-core/src/main/java/cz/habarta/typescript/generator/ext/EnumConstantsExtension.java

@@ -1,6 +1,7 @@
 
 package cz.habarta.typescript.generator.ext;
 
+import cz.habarta.typescript.generator.DeprecationText;
 import cz.habarta.typescript.generator.Settings;
 import cz.habarta.typescript.generator.compiler.EnumMemberModel;
 import cz.habarta.typescript.generator.emitter.EmitterExtension;
@@ -9,7 +10,6 @@
 import cz.habarta.typescript.generator.emitter.TsModel;
 import java.util.Collections;
 import java.util.List;
-import cz.habarta.typescript.generator.DeprecationText;
 
 
 @DeprecationText("Consider using configuration parameter 'mapEnum' with value 'asEnum'")

typescript-generator-core/src/main/java/cz/habarta/typescript/generator/ext/NonConstEnumsExtension.java

@@ -1,6 +1,7 @@
 
 package cz.habarta.typescript.generator.ext;
 
+import cz.habarta.typescript.generator.DeprecationText;
 import cz.habarta.typescript.generator.Settings;
 import cz.habarta.typescript.generator.compiler.EnumMemberModel;
 import cz.habarta.typescript.generator.emitter.EmitterExtension;
@@ -9,7 +10,6 @@
 import cz.habarta.typescript.generator.emitter.TsModel;
 import java.util.Collections;
 import java.util.List;
-import cz.habarta.typescript.generator.DeprecationText;
 
 
 @DeprecationText("Consider using parameter 'mapEnum' with value 'asEnum' and parameter 'nonConstEnums' with 'true'")

typescript-generator-core/src/main/java/cz/habarta/typescript/generator/parser/EnumModel.java

@@ -1,8 +1,8 @@
 
 package cz.habarta.typescript.generator.parser;
 
-import cz.habarta.typescript.generator.compiler.EnumMemberModel;
 import cz.habarta.typescript.generator.compiler.EnumKind;
+import cz.habarta.typescript.generator.compiler.EnumMemberModel;
 import java.util.*;
 
 

typescript-generator-core/src/main/java/cz/habarta/typescript/generator/parser/ModelParser.java

@@ -1,12 +1,11 @@
 
 package cz.habarta.typescript.generator.parser;
 
-import cz.habarta.typescript.generator.compiler.EnumMemberModel;
+import cz.habarta.typescript.generator.*;
 import cz.habarta.typescript.generator.compiler.EnumKind;
+import cz.habarta.typescript.generator.compiler.EnumMemberModel;
 import cz.habarta.typescript.generator.compiler.SymbolTable;
-import cz.habarta.typescript.generator.*;
 import java.lang.annotation.Annotation;
-import java.lang.reflect.AnnotatedElement;
 import java.lang.reflect.Field;
 import java.lang.reflect.Member;
 import java.lang.reflect.Method;

typescript-generator-core/src/test/java/cz/habarta/typescript/generator/GenericsTest.java

@@ -4,8 +4,8 @@
 import com.fasterxml.jackson.annotation.JsonTypeInfo.As;
 import java.io.StringWriter;
 import java.util.*;
-import org.junit.Test;
 import static org.junit.Assert.assertEquals;
+import org.junit.Test;
 
 
 public class GenericsTest {