rewrite feature syslog to use objects

Author: Lennart Betz

manifests/feature/syslog.pp

@@ -0,0 +1,55 @@
+# == Class: icinga2::feature::syslog
+#
+# This module configures the Icinga2 feature syslog.
+#
+# === Parameters
+#
+# [*ensure*]
+#   Set to present enables the feature syslog, absent disables it. Defaults to present.
+#
+# [*severity*]
+#   You can choose the log severity between information, notice, warning or debug.
+#   Defaults to warning.
+#
+# === Authors
+#
+# Icinga Development Team <[email protected]>
+#
+class icinga2::feature::syslog(
+  $ensure   = present,
+  $severity = 'warning',
+) {
+
+  include ::icinga2::params
+
+  $conf_dir = $::icinga2::params::conf_dir
+
+  # validation
+  validate_re($ensure, [ '^present$', '^absent$' ],
+    "${ensure} isn't supported. Valid values are 'present' and 'absent'.")
+  validate_re($severity, ['^information$','^notice$','^warning$','^debug$'])
+
+  # compose attributes
+  $attrs = {
+    severity => $severity,
+  }
+
+  # create object
+  icinga2::object { "icinga2::object::SyslogLogger::syslog":
+    object_name => 'syslog',
+    object_type => 'SyslogLogger',
+    attrs       => $attrs,
+    target      => "${conf_dir}/features-available/syslog.conf",
+    order       => '10',
+    notify      => $ensure ? {
+      'present' => Class['::icinga2::service'],
+      default   => undef,
+    },
+  }
+
+  # manage feature
+  icinga2::feature { 'syslog':
+    ensure => $ensure,
+  }
+}
+

spec/classes/syslog_spec.rb

@@ -0,0 +1,140 @@
+require 'spec_helper'
+
+describe('icinga2::feature::syslog', :type => :class) do
+  let(:pre_condition) { [
+    "class { 'icinga2': features => [], }"
+  ] }
+
+  on_supported_os.each do |os, facts|
+    let :facts do
+      facts
+    end
+
+
+    context "#{os} with ensure => present" do
+      let(:params) { {:ensure => 'present'} }
+
+      it { is_expected.to contain_icinga2__feature('syslog').with({'ensure' => 'present'}) }
+
+      it { is_expected.to contain_icinga2__object('icinga2::object::SyslogLogger::syslog')
+        .with({ 'target' => '/etc/icinga2/features-available/syslog.conf' })
+        .that_notifies('Class[icinga2::service]') }
+    end
+
+
+    context "#{os} with ensure => absent" do
+      let(:params) { {:ensure => 'absent'} }
+
+      it { is_expected.to contain_icinga2__feature('syslog').with({'ensure' => 'absent'}) }
+
+      it { is_expected.to contain_icinga2__object('icinga2::object::SyslogLogger::syslog')
+        .with({ 'target' => '/etc/icinga2/features-available/syslog.conf' }) }
+    end
+
+
+    context "#{os} with all defaults" do
+      it { is_expected.to contain_icinga2__feature('syslog').with({'ensure' => 'present'}) }
+
+      it { is_expected.to contain_concat__fragment('icinga2::object::SyslogLogger::syslog')
+        .with({ 'target' => '/etc/icinga2/features-available/syslog.conf' })
+        .with_content(/severity = "warning"/) }
+    end
+
+
+    context "#{os} with severity => notice" do
+      let(:params) { {:severity => 'notice'} }
+
+      it { is_expected.to contain_concat__fragment('icinga2::object::SyslogLogger::syslog')
+        .with({ 'target' => '/etc/icinga2/features-available/syslog.conf' })
+        .with_content(/severity = "notice"/) }
+    end
+
+
+    context "#{os} with severity => foo (not a valid value)" do
+      let(:params) { {:severity => 'foo'} }
+
+      it { is_expected.to raise_error(Puppet::Error, /"foo" does not match/) }
+    end
+  end
+
+
+  context 'Windows 2012 R2 with ensure => present' do
+    let(:facts) { {
+      :kernel => 'Windows',
+      :architecture => 'x86_64',
+      :osfamily => 'Windows',
+      :operatingsystem => 'Windows',
+      :operatingsystemmajrelease => '2012 R2'
+    } }
+    let(:params) { {:ensure => 'present'} }
+
+    it { is_expected.to contain_icinga2__feature('syslog').with({'ensure' => 'present'}) }
+
+    it { is_expected.to contain_icinga2__object('icinga2::object::SyslogLogger::syslog')
+      .with({ 'target' => 'C:/ProgramData/icinga2/etc/icinga2/features-available/syslog.conf' })
+      .that_notifies('Class[icinga2::service]') }
+  end
+
+
+  context 'Windows 2012 R2 with ensure => absent' do
+    let(:facts) { {
+      :kernel => 'Windows',
+      :architecture => 'x86_64',
+      :osfamily => 'Windows',
+      :operatingsystem => 'Windows',
+      :operatingsystemmajrelease => '2012 R2'
+    } }
+    let(:params) { {:ensure => 'absent'} }
+
+    it { is_expected.to contain_icinga2__feature('syslog').with({'ensure' => 'absent'}) }
+
+    it { is_expected.to contain_icinga2__object('icinga2::object::SyslogLogger::syslog')
+      .with({ 'target' => 'C:/ProgramData/icinga2/etc/icinga2/features-available/syslog.conf' }) }
+  end
+
+
+  context "Windows 2012 R2 with all defaults" do
+    let(:facts) { {
+      :kernel => 'Windows',
+      :architecture => 'x86_64',
+      :osfamily => 'Windows',
+      :operatingsystem => 'Windows',
+      :operatingsystemmajrelease => '2012 R2'
+    } }
+    it { is_expected.to contain_icinga2__feature('syslog').with({'ensure' => 'present'}) }
+
+    it { is_expected.to contain_concat__fragment('icinga2::object::SyslogLogger::syslog')
+      .with({ 'target' => 'C:/ProgramData/icinga2/etc/icinga2/features-available/syslog.conf' })
+      .with_content(/severity = "warning"/) }
+  end
+
+
+  context 'Windows 2012 R2 with severity => notice' do
+    let(:facts) { {
+      :kernel => 'Windows',
+      :architecture => 'x86_64',
+      :osfamily => 'Windows',
+      :operatingsystem => 'Windows',
+      :operatingsystemmajrelease => '2012 R2'
+    } }
+    let(:params) { {:severity => 'notice'} }
+
+    it { is_expected.to contain_concat__fragment('icinga2::object::SyslogLogger::syslog')
+      .with({ 'target' => 'C:/ProgramData/icinga2/etc/icinga2/features-available/syslog.conf' })
+      .with_content(/severity = "notice"/) }
+  end
+
+
+  context 'Windows 2012 R2 with severity => foo (not a valid value)' do
+    let(:facts) { {
+      :kernel => 'Windows',
+      :architecture => 'x86_64',
+      :osfamily => 'Windows',
+      :operatingsystem => 'Windows',
+      :operatingsystemmajrelease => '2012 R2'
+    } }
+    let(:params) { {:severity => 'foo'} }
+
+    it { is_expected.to raise_error(Puppet::Error, /"foo" does not match/) }
+  end
+end