ci: mark 9 slow SDP tests, skip on non-coverage CI jobs

Saves ~6 minutes on 7 of 8 matrix jobs by skipping expensive SDP
tests (bell_inequality I3322, PPT distinguishability YYD, extended
nonlocal game quantum bounds). Slow tests still run on the coverage
job (ubuntu, Python 3.12) via --runslow flag.

Author: vprusso

.github/workflows/build-test-actions.yml

@@ -55,10 +55,10 @@ jobs:
           uv sync --group dev --no-group docs --no-group lint
       - name: Run tests
         if: matrix.python-version != '3.12' || matrix.os != 'ubuntu-latest'
-        run: uv run pytest -v
-      - name: Run tests with coverage
+        run: uv run pytest -v -m "not slow"
+      - name: Run tests with coverage (including slow tests)
         if: matrix.python-version == '3.12' && matrix.os == 'ubuntu-latest'
-        run: uv run pytest -v --cov-config=.coveragerc --cov-report=xml --cov-report term-missing:skip-covered --cov=toqito
+        run: uv run pytest -v --runslow --cov-config=.coveragerc --cov-report=xml --cov-report term-missing:skip-covered --cov=toqito
       - name: Upload coverage information
         if: matrix.python-version == '3.12' && matrix.os == 'ubuntu-latest'
         uses: codecov/codecov-action@v5

conftest.py

@@ -0,0 +1,23 @@
+"""Root conftest for toqito test suite."""
+
+import pytest
+
+
+def pytest_addoption(parser):
+    """Add --runslow command-line option."""
+    parser.addoption("--runslow", action="store_true", default=False, help="run slow tests")
+
+
+def pytest_configure(config):
+    """Register the slow marker."""
+    config.addinivalue_line("markers", "slow: marks tests as slow (deselect with '-m \"not slow\"')")
+
+
+def pytest_collection_modifyitems(config, items):
+    """Skip slow tests unless --runslow is given."""
+    if config.getoption("--runslow"):
+        return
+    skip_slow = pytest.mark.skip(reason="need --runslow option to run")
+    for item in items:
+        if "slow" in item.keywords:
+            item.add_marker(skip_slow)

toqito/nonlocal_games/tests/test_extended_nonlocal_game.py

@@ -477,13 +477,15 @@ def test_four_mub_unentangled_value(self):
         expected = (3 + np.sqrt(5)) / 8
         self.assertAlmostEqual(res, expected, places=5)
 
+    @pytest.mark.slow
     def test_four_mub_quantum_lower_bound(self):
         """Quantum heuristic lower bound of the 4-MUB game."""
         pi, pred_mat = self.four_mub_game()
         game = ExtendedNonlocalGame(pi, pred_mat)
         lb = game.quantum_value_lower_bound(initial_bob_is_random=True, seed=42, iters=50, tol=1e-6, verbose=False)
         self.assertAlmostEqual(lb, 0.660986, delta=7e-3)
 
+    @pytest.mark.slow
     def test_four_mub_npa_upper_bound_k1ab(self):
         """NPA upper bound at k='1+ab' for the 4-MUB game."""
         pi, pred_mat = self.four_mub_game()
@@ -520,6 +522,7 @@ def _get_bb84_game(self):
         prob_mat[1, 1] = 1 / 2
         return ExtendedNonlocalGame(prob_mat, pred_mat)
 
+    @pytest.mark.slow
     def test_quantum_lb_max_steps_reached_verbose_print(self, capsys):
         """Test verbose print when see-saw reaches max steps."""
         game = self._get_bb84_game()

toqito/nonlocal_games/tests/test_nonlocal_game.py

@@ -3,6 +3,7 @@
 import unittest
 
 import numpy as np
+import pytest
 
 from toqito.nonlocal_games.nonlocal_game import NonlocalGame
 
@@ -168,6 +169,7 @@ def test_ffl_game_classical_value_rep_2(self):
         expected_res = 2 / 3
         self.assertEqual(np.isclose(res, expected_res), True)
 
+    @pytest.mark.slow
     def test_ffl_game_quantum_value_lower_bound_value_rep_2(self):
         """Lower bound on quantum value for the FFL game for 2 reps."""
         prob_mat, pred_mat = self.ffl_nonlocal_game()

toqito/state_opt/tests/test_bell_inequality_max.py

@@ -558,34 +558,29 @@ def test_classical_nonbinary_cg_to_fp_internal_error():
 # --- Qubit Solver Tests ---
 
 
-@pytest.mark.parametrize(
-    "joint_coe, a_coe, b_coe, a_val, b_val, expected",
-    # Bell I3322 inequality.
-    [
-        (
-            np.array([[1, 1, -1], [1, 1, 1], [-1, 1, 0]]),
-            np.array([0, -1, 0]),
-            np.array([-1, -2, 0]),
-            np.array([0, 1]),
-            np.array([0, 1]),
-            0.250,
-        ),
-        # Bell CHSH inequality.
-        (
-            np.array([[1, 1], [1, -1]]),
-            np.array([0, 0]),
-            np.array([0, 0]),
-            np.array([1, -1]),
-            np.array([1, -1]),
-            2 * np.sqrt(2),
-        ),
-    ],
-)
-def test_bell_inequality_max_qubits_valid(joint_coe, a_coe, b_coe, a_val, b_val, expected):
-    """Test bell_inequality_max_qubits returns the expected value using valid input."""
-    # Call via module alias
-    result = bim.bell_inequality_max_qubits(joint_coe, a_coe, b_coe, a_val, b_val)
-    assert pytest.approx(result, 0.01) == expected
+@pytest.mark.slow
+def test_bell_inequality_max_qubits_i3322():
+    """Test bell_inequality_max_qubits with I3322 inequality (slow SDP)."""
+    result = bim.bell_inequality_max_qubits(
+        np.array([[1, 1, -1], [1, 1, 1], [-1, 1, 0]]),
+        np.array([0, -1, 0]),
+        np.array([-1, -2, 0]),
+        np.array([0, 1]),
+        np.array([0, 1]),
+    )
+    assert pytest.approx(result, 0.01) == 0.250
+
+
+def test_bell_inequality_max_qubits_chsh():
+    """Test bell_inequality_max_qubits with CHSH inequality."""
+    result = bim.bell_inequality_max_qubits(
+        np.array([[1, 1], [1, -1]]),
+        np.array([0, 0]),
+        np.array([0, 0]),
+        np.array([1, -1]),
+        np.array([1, -1]),
+    )
+    assert pytest.approx(result, 0.01) == 2 * np.sqrt(2)
 
 
 @pytest.mark.parametrize(

toqito/state_opt/tests/test_ppt_distinguishability.py

@@ -7,6 +7,7 @@
 from toqito.states import basis, bell
 
 
+@pytest.mark.slow
 def test_ppt_distinguishability_yyd_density_matrices():
     """PPT distinguishing the YYD states from :footcite:`Yu_2012_Four` should yield `7/8 ~ 0.875`.
 
@@ -62,6 +63,7 @@ def test_ppt_distinguishability_yyd_density_matrices():
     assert np.isclose(primal_res, 3 / 4, atol=0.001)
 
 
+@pytest.mark.slow
 def test_ppt_distinguishability_yyd_vectors():
     """PPT distinguishing the YYD states from :footcite:`Yu_2012_Four` should yield `7/8 ~ 0.875`.
 
@@ -113,6 +115,7 @@ def test_ppt_distinguishability_yyd_vectors():
     assert np.isclose(primal_res, 3 / 4, atol=0.001)
 
 
+@pytest.mark.slow
 def test_ppt_distinguishability_yyd_states_no_probs():
     """PPT distinguishing the YYD states from :footcite:`Yu_2012_Four` should yield `7/8 ~ 0.875`.
 
@@ -153,6 +156,7 @@ def test_ppt_distinguishability_yyd_states_no_probs():
     assert np.isclose(primal_res, 3 / 4, atol=0.001)
 
 
+@pytest.mark.slow
 def test_ppt_distinguishability_four_bell_states():
     r"""PPT distinguishing the four Bell states.