Skip to content

Commit a2bb3a2

Browse files
aniamusialFRSgit
andauthored
fix!: changed paddings in sfselect (#2864)
* fix: changed paddings in sfselect * chore: adjusted padding left * chore: updated changelog * Update .changeset/fresh-emus-care.md Co-authored-by: Jakub Freisler <[email protected]> --------- Co-authored-by: Jakub Freisler <[email protected]>
1 parent 33935c6 commit a2bb3a2

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

.changeset/fresh-emus-care.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@storefront-ui/react': major
3+
'@storefront-ui/vue': major
4+
---
5+
6+
Breaking Change - Padding left and right in SfSelect changed from 14px and 16px to 12px

packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export default function SfSelect(props: SfSelectProps) {
4545
required={required}
4646
disabled={disabled}
4747
className={classNames(
48-
'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3.5 text-neutral-900 focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-inset ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200',
48+
'appearance-none disabled:cursor-not-allowed cursor-pointer px-3 text-neutral-900 focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-inset ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200',
4949
{
5050
'py-1.5': size === SfSelectSize.sm,
5151
'py-2': size === SfSelectSize.base,

packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ const changedValue = (event: Event) => {
7373
:required="required"
7474
:disabled="disabled"
7575
:class="[
76-
'appearance-none disabled:cursor-not-allowed cursor-pointer pl-4 pr-3.5 text-neutral-900 ring-inset focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200',
76+
'appearance-none disabled:cursor-not-allowed cursor-pointer px-3 text-neutral-900 ring-inset focus:ring-primary-700 focus:ring-2 outline-none bg-transparent rounded-md ring-1 ring-neutral-300 hover:ring-primary-700 active:ring-2 active:ring-primary-700 disabled:bg-disabled-100 disabled:text-disabled-900 disabled:ring-disabled-200',
7777
{
7878
'py-1.5': size === SfSelectSize.sm,
7979
'py-2': size === SfSelectSize.base,

0 commit comments

Comments
 (0)