-
Notifications
You must be signed in to change notification settings - Fork 459
feat: tailwind 4 migration #3281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* fix: changed paddings in sfselect * chore: adjusted padding left * chore: updated changelog * Update .changeset/fresh-emus-care.md Co-authored-by: Jakub Freisler <[email protected]> --------- Co-authored-by: Jakub Freisler <[email protected]>
* BREAKING CHANGE: remove flex classes form wrapper slot in list item * fix: lint fixes * fix: lint fixes
#3008) BREAKING CHANGE: remove deprecated useTrapFocus arrowKeysOn option
🦋 Changeset detectedLatest commit: 258f8b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
looking forward to use it with tailwind v4 |
# Conflicts: # apps/docs/components/content/_hooks/useTrapFocus.md # packages/sfui/frameworks/react/components/SfListItem/SfListItem.tsx # packages/sfui/frameworks/vue/components/SfListItem/SfListItem.vue # packages/sfui/frameworks/vue/composables/useTrapFocus/useTrapFocus.ts # packages/tests/components/SfButton/SfButton.cy.tsx
# Conflicts: # apps/docs/components/components/content/ColorPaletteBlock.vue # apps/preview/next/package.json # apps/preview/next/pages/examples/SfAccordionItem.tsx # apps/preview/next/pages/showcases/ProductCard/Details.tsx # apps/preview/next/pages/showcases/ProductCard/ProductCardHorizontal.tsx # apps/preview/next/pages/showcases/QuantitySelector/OutOfStock.tsx # apps/preview/next/pages/showcases/QuantitySelector/QuantitySelector.tsx # apps/preview/next/pages/showcases/QuantitySelector/Rounded.tsx # apps/preview/nuxt/pages/examples/SfAccordionItem.vue # apps/test/react/package.json # apps/test/vue/package.json # package.json # packages/config/tailwind/index.ts # packages/config/tailwind/package.json # packages/sfui/frameworks/react/components/SfButton/SfButton.tsx # packages/sfui/frameworks/react/components/SfCheckbox/SfCheckbox.tsx # packages/sfui/frameworks/react/components/SfChip/SfChip.tsx # packages/sfui/frameworks/react/components/SfInput/SfInput.tsx # packages/sfui/frameworks/react/components/SfLink/SfLink.tsx # packages/sfui/frameworks/react/components/SfModal/SfModal.tsx # packages/sfui/frameworks/react/components/SfSelect/SfSelect.tsx # packages/sfui/frameworks/react/components/SfTextarea/SfTextarea.tsx # packages/sfui/frameworks/vue/components/SfAccordionItem/SfAccordionItem.vue # packages/sfui/frameworks/vue/components/SfButton/SfButton.vue # packages/sfui/frameworks/vue/components/SfCheckbox/SfCheckbox.vue # packages/sfui/frameworks/vue/components/SfChip/SfChip.vue # packages/sfui/frameworks/vue/components/SfInput/SfInput.vue # packages/sfui/frameworks/vue/components/SfLink/SfLink.vue # packages/sfui/frameworks/vue/components/SfModal/SfModal.vue # packages/sfui/frameworks/vue/components/SfSelect/SfSelect.vue # packages/sfui/frameworks/vue/components/SfTextarea/SfTextarea.vue # yarn.lock
patch sf-docs-base to handle new tailwind
215ac83 to
89effc8
Compare
89effc8 to
d9f00e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Titanic work, great PR!
I approved in advance, and leave only couple of questions !
| "@nuxtjs/color-mode": "^3.4.2", | ||
| "@nuxtjs/seo": "^2.0.0-rc.10", | ||
| "@nuxtjs/tailwindcss": "^6.12.1", | ||
| "@nuxtjs/tailwindcss": "7.0.0-beta.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beta :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the only version that works with tailwind 4. Do you think that some info about this fact should be added in the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure really tbh
ddd2abc to
beda435
Compare
beda435 to
6f28f8e
Compare
…refront/storefront-ui into feat/tailwind-4-migration
Related issue
Closes #
Scope of work
https://tailwindcss.com/docs/upgrade-guide
To avoid some of the breaking changes introduced by Tailwind 4 and to keep sensible defaults we want to give to out users, SFUI Tailwind configuration:
cursor: pointerstyle for button elements.Screenshots of visual changes
Checklist