Skip to content

podman: T9129: Fix podman prefix directory - #1277

Merged
jestabro merged 1 commit into
vyos:rollingfrom
sarthurdev:T9129
Aug 23, 2026
Merged

podman: T9129: Fix podman prefix directory#1277
jestabro merged 1 commit into
vyos:rollingfrom
sarthurdev:T9129

Conversation

@sarthurdev

Copy link
Copy Markdown
Member

Change summary

Podman currently builds with an incorrect prefix directory. Quadlets incorrectly refer to /usr/local/bin instead of /usr/bin.

This fix is required before podman quadlets PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

strings from binary in podman deb from vyos repo:

root@dev-test:~/temp/podman-deb/usr/lib/systemd/system-generators# strings podman-system-generator | grep '/usr/local/bin'
/usr/local/bin
build	-ldflags="<truncated>  -X github.com/containers/podman/v5/libpod/config._installPrefix=/usr/local <truncated> -X github.com/containers/podman/v5/pkg/systemd/quadlet._binDir=/usr/local/bin ..."

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Warning

Your free Security trial is over. An organization admin can activate billing to continue.

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 83e0c1e7-932c-42e9-a660-ccf7d711060d

📥 Commits

Reviewing files that changed from the base of the PR and between 339947b and 54daf7c.

📒 Files selected for processing (1)
  • scripts/package-build/podman/package.toml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • ansible/ansible (manual)

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: CodeQL
  • GitHub Check: codeql-analysis-call / Analyze (python)
  • GitHub Check: Mergify Merge Protections
  • GitHub Check: Summary
🧰 Additional context used
🔍 Remote MCP vyos.dev

Relevant task context

  • T9129 — “Migrate podman to systemd quadlets” is In progress, with Normal priority.
  • The task states that existing generated systemd units have issues when migrating to Trixie, motivating Podman Quadlets as the future-proof solution.
  • T9129 has no comments or additional acceptance criteria.

This PR’s prefix correction appears to be a prerequisite for the broader Quadlet migration rather than completion of T9129 itself.

🔇 Additional comments (1)
scripts/package-build/podman/package.toml (1)

180-180: LGTM!


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the Podman release build configuration to install packaged files under the standard /usr prefix.

Walkthrough

The Podman release packaging command now sets PREFIX=/usr explicitly. Other packaging steps remain unchanged.

Changes

Podman release packaging

Layer / File(s) Summary
Set the release installation prefix
scripts/package-build/podman/package.toml
At line 180, the make podman-release invocation passes PREFIX=/usr instead of using the Makefile default.

Merge Risk: ⚪ Minimal · up to 54daf

This is a localized correction to Podman’s installation prefix so Quadlets reference the intended binary directory; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Podman prefix directory fix and includes the related task ID.
Description check ✅ Passed The description explains the incorrect Podman prefix, its quadlet impact, and the purpose of the fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the rolling label Aug 22, 2026
@sarthurdev
sarthurdev requested a review from jestabro August 22, 2026 19:04

@jestabro jestabro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set correct prefix instead of relying on default /usr/local/bin.

@mergify

mergify Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@jestabro
jestabro merged commit 14d959f into vyos:rolling Aug 23, 2026
11 checks passed
@vyos-bot vyos-bot Bot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants