-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Hi @wang-boyu - thanks for submitting this package to JOSS, it looks good. I'm going to raise a few issues but all should be fixable.
The code snippets in the README (and docs front page) refer to 'path/to/your/geospatial_data.shp' without specifying what that should contain.
- I'd suggest using a
GeoDataFrameliteral here, or a small example dataset e.g. from geodatasets as geopandas uses for some tutorials. - Note any restrictions on geometry types - as I understand it, the methods accept either all
Pointor allPolygon
Line 29 in 6945f88
| gdf = gpd.read_file('path/to/your/geospatial_data.shp') |
import geodatasets
# ...
gdf = gpd.read_file(geodatasets.get_path("geoda groceries")).explode() # explode to go from Multi- to PointsPart of openjournals/joss-reviews#9346
Metadata
Metadata
Assignees
Labels
No labels