Commit 80e4784
committed
Make the pin button's hover fill visible on selected pills
`fg_overlay_1` is the theme foreground at 5% opacity, and a selected pill's
background is that same foreground colour at full opacity. Hovering the pin
button on a selected chip therefore painted a colour onto itself and produced
no visual change at all.
That is not an edge case: `drill_down_anchor_id` anchors the bar on the parent
of whatever leaf conversation you are viewing, so the active child renders as a
selected, pinnable child pill. Selected-and-hovered is the state users are in
most of the time.
Tint with the pill's own contrasting colour instead -- the one it already
computes for its text and icons, which flips with selection -- so the fill has
contrast in both states. 8% rather than 5% because the contrasting colour
starts further from the pill's background than the foreground overlay did.
Co-Authored-By: Warp Agent <agent@warp.dev>1 parent 952c413 commit 80e4784
1 file changed
Lines changed: 12 additions & 3 deletions
Lines changed: 12 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1996 | 1996 | | |
1997 | 1997 | | |
1998 | 1998 | | |
1999 | | - | |
2000 | 1999 | | |
2001 | 2000 | | |
2002 | 2001 | | |
2003 | | - | |
| 2002 | + | |
| 2003 | + | |
| 2004 | + | |
| 2005 | + | |
| 2006 | + | |
| 2007 | + | |
| 2008 | + | |
2004 | 2009 | | |
2005 | 2010 | | |
2006 | 2011 | | |
| |||
2177 | 2182 | | |
2178 | 2183 | | |
2179 | 2184 | | |
2180 | | - | |
2181 | 2185 | | |
2182 | 2186 | | |
2183 | 2187 | | |
| |||
2391 | 2395 | | |
2392 | 2396 | | |
2393 | 2397 | | |
| 2398 | + | |
| 2399 | + | |
| 2400 | + | |
| 2401 | + | |
| 2402 | + | |
2394 | 2403 | | |
2395 | 2404 | | |
2396 | 2405 | | |
| |||
0 commit comments