Commit e38e0c3
committed
Delete the unreachable anonymous-user AI sign-up banner
Removing `insert_anonymous_user_ai_sign_up_banner` in the previous commit
took away the banner's only entry point, and everything left behind is a
closed cycle: the field it wrote is now permanently `None`, so the render
site can never fire, so the action can never dispatch, so the handler and
the remover that handler calls can never run. Every member of that cycle
is still referenced by another member, which is why clippy reports nothing
even though the whole feature is unreachable — it has to be cut by hand.
`AnonymousUserAISignUpBannerState` had exactly one constructor call and the
field exactly one assignment, both inside the deleted inserter; the struct
has no derives and no test or debug-only path builds one.
The `anonymous_user_ai_sign_up_banner_shown` setting goes with it. It was
read and written only by the inserter. It is `private: true` and
`SyncToCloud::Never`, so nothing was ever written to the cloud, and every
preferences backend is a plain key-value map read per key through
`storage_key()`. Nothing enumerates the store to validate it against known
settings, so the key existing but unread in a current user's local
preferences is inert.1 parent a87eafe commit e38e0c3
5 files changed
Lines changed: 10 additions & 308 deletions
File tree
- app/src/terminal
- view
- inline_banner
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | 162 | | |
171 | 163 | | |
172 | 164 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| |||
1017 | 1017 | | |
1018 | 1018 | | |
1019 | 1019 | | |
1020 | | - | |
1021 | 1020 | | |
1022 | 1021 | | |
1023 | 1022 | | |
| |||
1031 | 1030 | | |
1032 | 1031 | | |
1033 | 1032 | | |
1034 | | - | |
1035 | 1033 | | |
1036 | 1034 | | |
1037 | 1035 | | |
| |||
1091 | 1089 | | |
1092 | 1090 | | |
1093 | 1091 | | |
1094 | | - | |
1095 | | - | |
1096 | 1092 | | |
1097 | 1093 | | |
1098 | 1094 | | |
| |||
10706 | 10702 | | |
10707 | 10703 | | |
10708 | 10704 | | |
10709 | | - | |
10710 | | - | |
10711 | | - | |
10712 | | - | |
10713 | | - | |
10714 | | - | |
10715 | | - | |
10716 | | - | |
10717 | | - | |
10718 | | - | |
10719 | | - | |
10720 | | - | |
10721 | | - | |
10722 | | - | |
10723 | | - | |
10724 | | - | |
10725 | | - | |
10726 | | - | |
10727 | | - | |
10728 | | - | |
10729 | | - | |
10730 | | - | |
10731 | | - | |
10732 | | - | |
10733 | | - | |
10734 | | - | |
10735 | | - | |
10736 | | - | |
10737 | | - | |
10738 | | - | |
10739 | | - | |
10740 | | - | |
10741 | 10705 | | |
10742 | 10706 | | |
10743 | 10707 | | |
| |||
24347 | 24311 | | |
24348 | 24312 | | |
24349 | 24313 | | |
24350 | | - | |
24351 | | - | |
24352 | | - | |
24353 | | - | |
24354 | 24314 | | |
24355 | 24315 | | |
24356 | 24316 | | |
| |||
26891 | 26851 | | |
26892 | 26852 | | |
26893 | 26853 | | |
26894 | | - | |
26895 | 26854 | | |
26896 | 26855 | | |
26897 | 26856 | | |
| |||
27644 | 27603 | | |
27645 | 27604 | | |
27646 | 27605 | | |
27647 | | - | |
27648 | | - | |
27649 | | - | |
27650 | 27606 | | |
27651 | 27607 | | |
27652 | 27608 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
| 18 | + | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
356 | 356 | | |
357 | 357 | | |
358 | 358 | | |
359 | | - | |
360 | 359 | | |
361 | 360 | | |
362 | 361 | | |
| |||
690 | 689 | | |
691 | 690 | | |
692 | 691 | | |
693 | | - | |
694 | | - | |
695 | | - | |
696 | 692 | | |
697 | 693 | | |
698 | 694 | | |
| |||
0 commit comments