Add check to instantiate for imported memory/table limits validity

Author: gumb0

lib/fizzy/instantiate.cpp

@@ -40,6 +40,9 @@ void match_imported_functions(const std::vector<FuncType>& module_imported_types
 
 void match_limits(const Limits& external_limits, const Limits& module_limits)
 {
+    if (external_limits.max.has_value() && external_limits.min > *external_limits.max)
+        throw instantiate_error{"provided import's min limit is above import's max limit"};
+
     if (external_limits.min < module_limits.min)
         throw instantiate_error{"provided import's min is below import's min defined in module"};
 

test/unittests/instantiate_test.cpp

@@ -179,7 +179,7 @@ TEST(instantiate, imported_table_invalid)
 
     // Provided limits have max less than min
     EXPECT_THROW_MESSAGE(instantiate(*module, {}, {{&table, {10, 0}}}), instantiate_error,
-        "provided imported table doesn't fit provided limits");
+        "provided import's min limit is above import's max limit");
 
     // Null pointer
     EXPECT_THROW_MESSAGE(instantiate(*module, {}, {{nullptr, {10, 30}}}), instantiate_error,
@@ -289,7 +289,7 @@ TEST(instantiate, imported_memory_invalid)
 
     // Provided limits have max less than min
     EXPECT_THROW_MESSAGE(instantiate(*module, {}, {}, {{&memory, {1, 0}}}), instantiate_error,
-        "provided imported memory doesn't fit provided limits");
+        "provided import's min limit is above import's max limit");
 
     // Null pointer
     EXPECT_THROW_MESSAGE(instantiate(*module, {}, {}, {{nullptr, {1, 3}}}), instantiate_error,