Handle image field changes on sync

[rolandgeider]

At the moment, when downloading exercise images, we simply check if the image is present locally and skip the loop if true so that in case some of the fields have been edited (e.g. the style or the license information), these don't get updated. We should proceed similarly to the exercises themselves, where we update them

wger.exercises.sync.download_exercise_images

[shihabhasan0161]

@rolandgeider, I would like to work on this issue. Just wondering if I need to be assigned first to work on it.

From my understanding of this problem, are you saying the image downloaded by the download_exercise_images function in sync.py doesn't download the updated image if the image was edited before the download? I'm guessing there has to be a problem with DB not updating the image in this case. I will definitely have a look at it to understand further myself. I would appreciate it if you could elaborate more on this. Thanks!

[rolandgeider]

sure @shihabhasan0161 I can assign you.

If you compare sync_exercises with download_exercise_images you see that in the case of the exercises, if the exercise already exists in the local db, we update the values so that they are the same as the ones upstream. In the case of the images, if the image already exists, we don't do anything. This was due to the fact that we mostly care about the image file itself, and other fields are not being used much, but it would still be cleaner if we made sure these are updated as well.

[shihabhasan0161]

thanks. I will have a look.