Skip to content

only update license key via IaC when new expiry is posterior#7959

Merged
rubenfiszel merged 1 commit intomainfrom
feat/iac-license-key-expiry-check
Feb 15, 2026
Merged

only update license key via IaC when new expiry is posterior#7959
rubenfiszel merged 1 commit intomainfrom
feat/iac-license-key-expiry-check

Conversation

@rubenfiszel
Copy link
Contributor

Summary

  • When using infrastructure-as-code (API endpoint or K8s operator) to update instance settings, the license key is now only updated if the new key has a later expiration date than the current one
  • This applies only when the license keys share the same client ID and signature (i.e. differ only in the expiry field). Completely different license keys are always applied
  • When a license key update is skipped, a tracing::info message is logged explaining the reason
  • Non-string license key values (e.g. envRef, secretKeyRef) fall through to the standard diff logic

Test plan

  • Unit test: skip update when desired expiry is older than current
  • Unit test: skip update when same key/signature, expiry equal (actually different sig → update)
  • Unit test: apply update when desired expiry is newer
  • Unit test: always apply when client ID or signature differ
  • Unit test: always apply when license key values are non-string (envRef/secretKeyRef)
  • All 55 existing instance_config tests still pass
  • cargo check -p windmill-common passes

🤖 Generated with Claude Code

When using infrastructure-as-code to update settings, if the desired
license key matches the current one (same client ID and signature) but
differs only in the expiration date, only apply the update if the new
key has a later expiry. This prevents accidental downgrades when an
older license key is present in the IaC configuration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude
Copy link
Contributor

claude bot commented Feb 15, 2026

Claude Code is working…

I'll analyze this and get back to you.

View job run

@rubenfiszel rubenfiszel changed the title feat: only update license key via IaC when new expiry is posterior only update license key via IaC when new expiry is posterior Feb 15, 2026
@rubenfiszel rubenfiszel merged commit 714f713 into main Feb 15, 2026
11 of 12 checks passed
@rubenfiszel rubenfiszel deleted the feat/iac-license-key-expiry-check branch February 15, 2026 17:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant