Skip to content

Conversation

@sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Oct 8, 2025

EpicWPB-20296 [Android] Adopt new API with Enterprise File Upload Metadata

https://wearezeta.atlassian.net/browse/WPB-20296

What's new in this PR?

  • Protocol version v12
  • New parameters for asset upload metadata for v12
  • NOT INCLUDED: setting new metadata params if feature flag is enabled

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Test Results

0 tests   - 3 946   0 ✅  - 3 835   0s ⏱️ - 5m 13s
0 suites  -   674   0 💤  -   111 
0 files    -   674   0 ❌ ±    0 

Results for commit 8acaf47. ± Comparison against base commit 59f0084.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 11.76471% with 165 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.54%. Comparing base (59f0084) to head (8acaf47).

Files with missing lines Patch % Lines
...tworkContainer/AuthenticatedNetworkContainerV12.kt 0.00% 51 Missing ⚠️
...orkContainer/UnauthenticatedNetworkContainerV12.kt 0.00% 28 Missing ⚠️
...alium/network/api/v12/authenticated/AssetApiV12.kt 0.00% 14 Missing ⚠️
.../networkContainer/AuthenticatedNetworkContainer.kt 0.00% 7 Missing ⚠️
...etworkContainer/UnauthenticatedNetworkContainer.kt 0.00% 6 Missing ⚠️
.../kalium/network/api/v0/authenticated/AssetApiV0.kt 78.57% 3 Missing ⚠️
...network/api/v12/authenticated/AccessTokenApiV12.kt 0.00% 2 Missing ⚠️
...kalium/network/api/v12/authenticated/CallApiV12.kt 0.00% 2 Missing ⚠️
...lium/network/api/v12/authenticated/ClientApiV12.kt 0.00% 2 Missing ⚠️
.../network/api/v12/authenticated/ConnectionApiV12.kt 0.00% 2 Missing ⚠️
... and 24 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3656      +/-   ##
===========================================
- Coverage    57.67%   57.54%   -0.13%     
===========================================
  Files         1744     1775      +31     
  Lines        64978    65157     +179     
  Branches      5726     5732       +6     
===========================================
+ Hits         37476    37495      +19     
- Misses       25079    25240     +161     
+ Partials      2423     2422       -1     
Files with missing lines Coverage Δ
...rk/api/authenticated/asset/AssetMetadataRequest.kt 100.00% <100.00%> (ø)
...lin/com/wire/kalium/network/BackendMetaDataUtil.kt 100.00% <100.00%> (ø)
.../kalium/network/api/v2/authenticated/AssetApiV2.kt 90.47% <100.00%> (+2.97%) ⬆️
...network/api/v12/authenticated/AccessTokenApiV12.kt 0.00% <0.00%> (ø)
...kalium/network/api/v12/authenticated/CallApiV12.kt 0.00% <0.00%> (ø)
...lium/network/api/v12/authenticated/ClientApiV12.kt 0.00% <0.00%> (ø)
.../network/api/v12/authenticated/ConnectionApiV12.kt 0.00% <0.00%> (ø)
...etwork/api/v12/authenticated/ConversationApiV12.kt 0.00% <0.00%> (ø)
...api/v12/authenticated/ConversationHistoryApiV12.kt 0.00% <0.00%> (ø)
...kalium/network/api/v12/authenticated/E2EIApiV12.kt 0.00% <0.00%> (ø)
... and 27 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f0084...8acaf47. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

🐰 Bencher Report

Branchfeat/protocol-v12
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
683.66 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
619,242.22 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,478,935.25 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
33,810.33 µs
🐰 View full continuous benchmarking report in Bencher

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! One thing missing is we need to add the development version 12 to BackendMetaDataUtil.kt if we want to start testing it 🚀

@sbakhtiarov
Copy link
Contributor Author

Added 12 as dev version

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

@MohamadJaara MohamadJaara added this pull request to the merge queue Oct 10, 2025
Merged via the queue into develop with commit 3f172f6 Oct 10, 2025
24 checks passed
@MohamadJaara MohamadJaara deleted the feat/protocol-v12 branch October 10, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants