Skip to content

Conversation

@zskhan
Copy link
Contributor

@zskhan zskhan commented Nov 18, 2025

TaskWPB-20284 [Web] Meeting list items for all states

Description

Meeting list items for all states
Buttons to start or schedule a meeting - WPB-20285
Meeting options menu - WPB-20286

Screenshots/Screencast (for UI changes)

Screen.Recording.2025-11-19.at.12.46.40.AM.mov

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

);
};

export const TodayAndOngoingSection = memo(TodayAndOngoingSectionComponent);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question about the memo

I get the feeling you just added them "in case". Let's not do that and let react decide

@sonarqubecloud
Copy link

@zskhan zskhan requested a review from aweiss-dev November 19, 2025 13:24
@zskhan zskhan changed the title feat: meeting list item states [WPB-18512] feat: meeting list item states [WPB-20284] Nov 19, 2025
Copy link
Member

@aweiss-dev aweiss-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the 1:1 call, I would like to see a different solution for the part of the code that is required to rerender every second just to display a timer and / or the list.

This needs to be implemented via "cron-jobs", either directly in the backend (best solution since they can notify all clients, not just web) or via our lowPrecisionTimeScheduler functionality in the webapp. A cron-job like implementation in our application already exists and can be utilised.
You can also reuse these events to send browser notifications or display information to the user in general troughout our application.

For reference: https://github.com/wireapp/wire-webapp/pull/16935/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants