-
Notifications
You must be signed in to change notification settings - Fork 296
feat: meeting list item states [WPB-20284] #19782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/WPB-18512-wire-meeting
Are you sure you want to change the base?
feat: meeting list item states [WPB-20284] #19782
Conversation
…eeting and check/update meeting status on every second.
...omponents/Meeting/MeetingList/MeetingListItemGroup/MeetingListItem/MeetingListItem.styles.ts
Outdated
Show resolved
Hide resolved
| ); | ||
| }; | ||
|
|
||
| export const TodayAndOngoingSection = memo(TodayAndOngoingSectionComponent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question about the memo
I get the feeling you just added them "in case". Let's not do that and let react decide
src/script/components/Meeting/MeetingList/TodayAndOngoingSection/TodayAndOngoingSection.tsx
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the 1:1 call, I would like to see a different solution for the part of the code that is required to rerender every second just to display a timer and / or the list.
This needs to be implemented via "cron-jobs", either directly in the backend (best solution since they can notify all clients, not just web) or via our lowPrecisionTimeScheduler functionality in the webapp. A cron-job like implementation in our application already exists and can be utilised.
You can also reuse these events to send browser notifications or display information to the user in general troughout our application.
For reference: https://github.com/wireapp/wire-webapp/pull/16935/files



Description
Meeting list items for all states
Buttons to start or schedule a meeting - WPB-20285
Meeting options menu - WPB-20286
Screenshots/Screencast (for UI changes)
Screen.Recording.2025-11-19.at.12.46.40.AM.mov
Checklist