fix(fetch): Enable pk finder in DELETE requests

stiv-pro · stiv-pro · commit 3862f6c51ecc · 2020-03-24T12:02:26.000+01:00
diff --git a/src/Entity/EntityFactory.php b/src/Entity/EntityFactory.php
@@ -174,14 +174,14 @@ public function fetchCollection(
         if(is_string($pks)){
             $pks = json_decode($pks, true);
         }
-       if(!$pks && in_array($request->getMethod(), ['POST', 'PATCH', 'PUT'])){
+       if(!$pks && in_array($request->getMethod(), ['POST', 'PATCH', 'PUT', 'DELETE'])){
             # POST/PATCH : Try to find PKs in body
             if (is_array($request->getParsedBody())) {
                 $finder = new PksFinder([$pkName]);
                 $pks    = $finder->find($request->getParsedBody());
             }
         }
-       
+
         $entityRequest->setPrimaryKey($pks);
 
         # Next, we create the query (ModelCriteria), based on Action class (which can alter the query)

Original file line number	Diff line number	Diff line change
`@@ -174,14 +174,14 @@ public function fetchCollection(`
`174`	`174`	`if(is_string($pks)){`
`175`	`175`	`$pks = json_decode($pks, true);`
`176`	`176`	`}`
`177`		`- if(!$pks && in_array($request->getMethod(), ['POST', 'PATCH', 'PUT'])){`
	`177`	`+ if(!$pks && in_array($request->getMethod(), ['POST', 'PATCH', 'PUT', 'DELETE'])){`
`178`	`178`	`# POST/PATCH : Try to find PKs in body`
`179`	`179`	`if (is_array($request->getParsedBody())) {`
`180`	`180`	`$finder = new PksFinder([$pkName]);`
`181`	`181`	`$pks = $finder->find($request->getParsedBody());`
`182`	`182`	`}`
`183`	`183`	`}`
`184`		`-`
	`184`	`+`
`185`	`185`	`$entityRequest->setPrimaryKey($pks);`
`186`	`186`
`187`	`187`	`# Next, we create the query (ModelCriteria), based on Action class (which can alter the query)`