Merge branch 'develop' into release/3.9.0

Author: joemcgill

src/API/Google/AdsCampaign.php

@@ -133,6 +133,13 @@ public function __construct( GoogleAdsClient $client, AdsCampaignBudget $budget,
 	 * @throws ExceptionWithResponseData When an ApiException is caught.
 	 */
 	public function get_campaigns( bool $exclude_removed = true, bool $fetch_criterion = true, array $args = [] ): array {
+		// No Ads account connected means no campaigns; AdsCampaignQuery::set_client() requires
+		// a non-zero Ads ID and throws InvalidProperty otherwise, which callers don't expect
+		// from this method (its documented @throws is ExceptionWithResponseData).
+		if ( ! $this->options->get_ads_id() ) {
+			return [];
+		}
+
 		try {
 			$query = ( new AdsCampaignQuery() )->set_client( $this->client, $this->options->get_ads_id() );
 

tests/Unit/API/Google/AdsCampaignTest.php

@@ -107,6 +107,14 @@ public function test_get_campaigns_empty_list() {
 		$this->assertEquals( [], $this->campaign->get_campaigns() );
 	}
 
+	public function test_get_campaigns_no_ads_id_returns_empty_list_without_throwing() {
+		$this->options = $this->createMock( OptionsInterface::class );
+		$this->options->method( 'get_ads_id' )->willReturn( 0 );
+		$this->campaign->set_options_object( $this->options );
+
+		$this->assertEquals( [], $this->campaign->get_campaigns() );
+	}
+
 	public function test_get_campaigns() {
 		$campaign_criterion_data = [
 			[