Break a retain cycle between a UIAction and UIViewController (#24993)

crazytonyli · web-flow · commit 2fd0f1cc1aef · 2025-11-17T17:27:42.000Z
diff --git a/WordPress/Classes/ViewRelated/Media/SiteMedia/Controllers/SiteMediaAddMediaMenuController.swift b/WordPress/Classes/ViewRelated/Media/SiteMedia/Controllers/SiteMediaAddMediaMenuController.swift
@@ -37,9 +37,14 @@ final class SiteMediaAddMediaMenuController: NSObject, PHPickerViewControllerDel
         }
         if blog.isHostedAtWPcom, blog.isQuotaAvailable {
             children += [
-                UIAction(title: Strings.viewUsage, subtitle: blog.quotaUsageShortDescription, image: UIImage(systemName: "opticaldiscdrive"), handler: { _ in
+                UIAction(
+                    title: Strings.viewUsage,
+                    subtitle: blog.quotaUsageShortDescription,
+                    image: UIImage(systemName: "opticaldiscdrive")
+                ) { [weak self, weak viewController] _ in
+                    guard let self, let viewController else { return }
                     self.showQuotaView(from: viewController)
-                })
+                }
             ]
         }
         return UIMenu(options: [.displayInline], children: children)

Original file line number	Diff line number	Diff line change
`@@ -37,9 +37,14 @@ final class SiteMediaAddMediaMenuController: NSObject, PHPickerViewControllerDel`
`37`	`37`	`}`
`38`	`38`	`if blog.isHostedAtWPcom, blog.isQuotaAvailable {`
`39`	`39`	`children += [`
`40`		`- UIAction(title: Strings.viewUsage, subtitle: blog.quotaUsageShortDescription, image: UIImage(systemName: "opticaldiscdrive"), handler: { _ in`
	`40`	`+ UIAction(`
	`41`	`+ title: Strings.viewUsage,`
	`42`	`+ subtitle: blog.quotaUsageShortDescription,`
	`43`	`+ image: UIImage(systemName: "opticaldiscdrive")`
	`44`	`+ ) { [weak self, weak viewController] _ in`
	`45`	`+ guard let self, let viewController else { return }`
`41`	`46`	`self.showQuotaView(from: viewController)`
`42`		`- })`
	`47`	`+ }`
`43`	`48`	`]`
`44`	`49`	`}`
`45`	`50`	`return UIMenu(options: [.displayInline], children: children)`