Fix onChange warnings (#24975)

Author: jkmassel

Modules/Sources/JetpackStats/Cards/RealtimeTopListCard.swift

@@ -42,7 +42,7 @@ struct RealtimeTopListCard: View {
         }
         .padding(.vertical, Constants.step3)
         .redacted(reason: viewModel.isFirstLoad ? .placeholder : [])
-        .onChange(of: selectedItem) { newValue in
+        .onChange(of: selectedItem) { oldValue, newValue in
             viewModel.loadData(for: newValue)
         }
     }

Modules/Sources/JetpackStats/Charts/BarChartView.swift

@@ -42,7 +42,7 @@ struct BarChartView: View {
         .accessibilityElement()
         .accessibilityLabel(Strings.Accessibility.chartContainer)
         .accessibilityHint(Strings.Accessibility.viewChartData)
-        .onChange(of: ObjectIdentifier(data)) { _ in
+        .onChange(of: ObjectIdentifier(data)) {
             tappedDataPoint = nil
         }
     }
@@ -287,7 +287,12 @@ struct BarChartView: View {
     }
 
     private func getSelectedDataPoints(at location: CGPoint, proxy: ChartProxy, geometry: GeometryProxy) -> SelectedDataPoints? {
-        let origin = geometry[proxy.plotAreaFrame].origin
+
+        guard let frame = proxy.plotFrame else {
+            return nil
+        }
+
+        let origin = geometry[frame].origin
         let location = CGPoint(
             x: location.x - origin.x,
             y: location.y - origin.y

Modules/Sources/JetpackStats/Charts/LineChartView.swift

@@ -35,7 +35,7 @@ struct LineChartView: View {
         .chartXSelection(value: $selectedDate)
         .animation(.spring, value: ObjectIdentifier(data))
         .onChange(of: selectedDate) {
-            selectedDataPoints = SelectedDataPoints.compute(for: $0, data: data)
+            selectedDataPoints = SelectedDataPoints.compute(for: $1, data: data)
         }
         .dynamicTypeSize(...DynamicTypeSize.xxxLarge)
         .accessibilityElement()

Modules/Sources/JetpackStats/Screens/AuthorStatsView.swift

@@ -55,8 +55,8 @@ struct AuthorStatsView: View {
         }
         .background(Constants.Colors.background)
         .animation(.spring, value: viewModel.data.map(ObjectIdentifier.init))
-        .onChange(of: dateRange) { newRange in
-            viewModel.dateRange = newRange
+        .onChange(of: dateRange) { oldValue, newValue in
+            viewModel.dateRange = newValue
         }
         .onAppear {
             context.tracker?.send(.authorStatsScreenShown)

Modules/Sources/JetpackStats/Screens/StatsMainView.swift

@@ -36,7 +36,7 @@ public struct StatsMainView: View {
                 .onAppear {
                     context.tracker?.send(.statsMainScreenShown)
                 }
-                .onChange(of: selectedTab) { newValue in
+                .onChange(of: selectedTab) { oldValue, newValue in
                     trackTabChange(from: selectedTab, to: newValue)
                 }
         } else {

Modules/Sources/JetpackStats/Views/CustomDateRangePicker.swift

@@ -116,7 +116,7 @@ struct CustomDateRangePicker: View {
     private var dateSelectionSection: some View {
         HStack(alignment: .bottom, spacing: 0) {
             datePickerColumn(label: Strings.DatePicker.from.uppercased(), selection: $startDate, alignment: .leading)
-                .onChange(of: startDate) { newValue in
+                .onChange(of: startDate) { oldValue, newValue in
                     // If start date is after end date, adjust end date to be one day after start
                     if newValue > endDate {
                         endDate = calendar.date(byAdding: .day, value: 1, to: newValue) ?? newValue
@@ -126,7 +126,7 @@ struct CustomDateRangePicker: View {
             Spacer(minLength: 32)
 
             datePickerColumn(label: Strings.DatePicker.to.uppercased(), selection: $endDate, alignment: .trailing)
-                .onChange(of: endDate) { newValue in
+                .onChange(of: endDate) { oldValue, newValue in
                     // If end date is before start date, adjust start date to be one day before end
                     if newValue < startDate {
                         startDate = calendar.date(byAdding: .day, value: -1, to: newValue) ?? newValue

Modules/Sources/JetpackStats/Views/Customization/TopListCardCustomizationView.swift

@@ -39,7 +39,7 @@ struct TopListCardCustomizationView: View {
                 }
             }
         }
-        .onChange(of: selectedItem) { newValue in
+        .onChange(of: selectedItem) { oldValue, newValue in
             if let newValue {
                 updateConfiguration(with: newValue)
             }

Modules/Sources/Support/UI/Support Conversations/SupportConversationView.swift

@@ -141,7 +141,7 @@ public struct SupportConversationView: View {
             .onAppear {
                 scrollToBottom(proxy: proxy)
             }
-            .onChange(of: conversation.messages.count) { _, _ in
+            .onChange(of: conversation.messages.count) {
                 scrollToBottom(proxy: proxy)
             }
         }

WordPress/Classes/ViewRelated/Blog/Blogging Prompts/Bloganuary/BloganuaryOverlayViewController.swift

@@ -142,7 +142,7 @@ private struct BloganuaryOverlayView: View {
                     .onAppear {
                         scrollViewHeight = geo.size.height
                     }
-                    .onChange(of: viewModel.orientation) { _ in
+                    .onChange(of: viewModel.orientation) {
                         // since onAppear is only called once, assign the value again every time the orientation changes.
                         scrollViewHeight = geo.size.height
                     }

WordPress/Classes/ViewRelated/Blog/Site Monitoring/PHPLogsView.swift

@@ -21,8 +21,8 @@ struct PHPLogsView: View {
         .onAppear {
             loadLogs(searchCriteria: searchCriteria)
         }
-        .onChange(of: searchCriteria) { value in
-            loadLogs(searchCriteria: value, reset: true)
+        .onChange(of: searchCriteria) { oldValue, newValue in
+            loadLogs(searchCriteria: newValue, reset: true)
         }
     }