Fix onChange warnings #24975
Merged
Fix onChange warnings #24975
+27
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
jkmassel
commented
Nov 7, 2025
| return nil | ||
| } | ||
|
|
||
| let origin = geometry[frame].origin |
Contributor
Author
There was a problem hiding this comment.
This warning was in the same file so I addressed it – plotAreaFrame was renamed to plotFrame and made optional.
jkmassel
force-pushed
the
fix/swiftui-warnings
branch
from
2335d14 to
57cef22
Compare
jkmassel
force-pushed
the
fix/swiftui-warnings
branch
from
57cef22 to
7d05866
Compare
|
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29692 | |
| Version | PR #24975 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 7d05866 | |
| Installation URL | 5g2ut4c59gcco |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29692 | |
| Version | PR #24975 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 7d05866 | |
| Installation URL | 7pp85pq0n95k0 |
crazytonyli
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bunch of Xcode warnings.
Testing instructions
I don't think there's a lot of testing to do – if you validate that I got the order of "oldValue, newValue" correct in the code this should be good to go.