fix: resolve cloneable field issues with select_advanced and switch (#1644)

Author: huongcodecb1992

js/clone.js

@@ -14,7 +14,7 @@
 
 				// Name attribute
 				var name = this.name;
-				if ( name && ! $field.closest( '.rwmb-group-clone' ).length ) {
+				if ( name && !$field.closest( '.rwmb-group-clone' ).length ) {
 					$field.attr( 'name', cloneIndex.replace( index, name, '[', ']', false ) );
 				}
 
@@ -60,7 +60,7 @@
 			var regex = new RegExp( cloneIndex.escapeRegex( before ) + '(\\d+)' + cloneIndex.escapeRegex( after ) + end ),
 				newValue = before + index + after;
 
-			return regex.test( value ) ? value.replace( regex, newValue ) : (alternative ? value + newValue : value );
+			return regex.test( value ) ? value.replace( regex, newValue ) : ( alternative ? value + newValue : value );
 		},
 
 		/**
@@ -94,7 +94,7 @@
 
 	// Object holds all method related to fields' value when clone.
 	var cloneValue = {
-		setDefault: function() {
+		setDefault: function () {
 			var $field = $( this );
 
 			if ( true !== $field.data( 'clone-default' ) ) {
@@ -107,25 +107,30 @@
 			if ( 'radio' === type ) {
 				$field.prop( 'checked', $field.val() === defaultValue );
 			} else if ( $field.hasClass( 'rwmb-checkbox' ) || $field.hasClass( 'rwmb-switch' ) ) {
-				$field.prop( 'checked', !! defaultValue );
+				$field.prop( 'checked', !!defaultValue );
 			} else if ( $field.hasClass( 'rwmb-checkbox_list' ) ) {
 				var value = $field.val();
 				$field.prop( 'checked', Array.isArray( defaultValue ) ? -1 !== defaultValue.indexOf( value ) : value == defaultValue );
 			} else if ( $field.is( 'select' ) ) {
 				$field.find( 'option[value="' + defaultValue + '"]' ).prop( 'selected', true );
-			} else if ( ! $field.hasClass( 'rwmb-hidden' ) ) {
+			} else if ( !$field.hasClass( 'rwmb-hidden' ) ) {
 				$field.val( defaultValue );
 			}
 		},
-		clear: function() {
+		clear: function () {
 			const $field = $( this ),
 				type = $field.attr( 'type' );
 
 			if ( 'radio' === type || 'checkbox' === type ) {
 				$field.prop( 'checked', false );
 			} else if ( $field.is( 'select' ) ) {
-				$field.prop( 'selectedIndex', 0 );
-			} else if ( ! $field.hasClass( 'rwmb-hidden' ) ) {
+				if ( $field.attr( 'multiple' ) ) {
+					$field.find( 'option' ).prop( 'selected', false );
+					$field.val( null ).trigger( 'change' );
+				} else {
+					$field.prop( 'selectedIndex', 0 );
+				}
+			} else if ( !$field.hasClass( 'rwmb-hidden' ) ) {
 				$field.val( '' );
 			}
 		}
@@ -146,20 +151,20 @@
 		$template.find( rwmb.inputSelectors ).each( function () {
 			this.id = this.id.includes( '_rwmb_template' ) ? this.id : this.id + '_rwmb_template';
 		} );
-		
+
 		// Clear fields' values.
-		var $inputs = $clone.find( rwmb.inputSelectors );		
+		var $inputs = $clone.find( rwmb.inputSelectors );
 		let count = $container.children( '.rwmb-clone' ).length;
-		
+
 		// The first clone should keep the default values.
 		if ( count > 1 ) {
 			$inputs.each( cloneValue.clear );
 		}
-		
+
 		$clone = $clone.removeClass( 'rwmb-clone-template' );
 		// Remove validation errors.
 		$clone.find( 'p.rwmb-error' ).remove();
-		
+
 		// Insert clone.
 		$clone.insertAfter( $last );
 		count++;
@@ -195,7 +200,7 @@
 		let offset = 1;
 
 		// Add the first clone if data-clone-empty-start = false
-		const cloneEmptyStart = $container[0].dataset.cloneEmptyStart ?? 0;
+		const cloneEmptyStart = $container[ 0 ].dataset.cloneEmptyStart ?? 0;
 
 		// If clone-empty-start is true, we need at least 1 item.
 		if ( cloneEmptyStart == 1 ) {
@@ -235,7 +240,7 @@
 
 		toggleRemoveButtons( $container );
 		toggleAddButton( $container );
-		sortClones.apply( $container[0] );
+		sortClones.apply( $container[ 0 ] );
 	}
 
 	function removeClone( e ) {
@@ -279,7 +284,7 @@
 				// Make the placeholder has the same height as dragged item
 				ui.placeholder.height( ui.item.outerHeight() );
 			},
-			stop: function( event, ui ) {
+			stop: function ( event, ui ) {
 				ui.item.trigger( 'mb_init_editors' );
 				ui.item.find( rwmb.inputSelectors ).first().trigger( 'mb_change' );
 			}
@@ -310,4 +315,4 @@
 	rwmb.sortClones = sortClones;
 	rwmb.toggleRemoveButtons = toggleRemoveButtons;
 	rwmb.toggleAddButton = toggleAddButton;
-} )( jQuery, rwmb );
+}( jQuery, rwmb ) );