Skip to content

Commit f21ef39

Browse files
committed
Update to govuk-frontend 5.1.0
1 parent dc0ec40 commit f21ef39

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<TreatWarningsAsErrors Condition="'$(Configuration)' == 'Release'">true</TreatWarningsAsErrors>
55
<RepoRoot>$([MSBuild]::EnsureTrailingSlash('$(MSBuildThisFileDirectory)'))</RepoRoot>
66
<Nullable>enable</Nullable>
7-
<GovUkFrontendVersion>5.0.0</GovUkFrontendVersion>
7+
<GovUkFrontendVersion>5.1.0</GovUkFrontendVersion>
88

99
<_NpmLibDirectory>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'lib'))</_NpmLibDirectory>
1010
<_NpmLibVersionFile>$([System.IO.Path]::Combine('$(_NpmLibDirectory)', 'version.txt'))</_NpmLibVersionFile>

src/GovUk.Frontend.AspNetCore/HtmlGeneration/ComponentGenerator.Accordion.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ public TagBuilder GenerateAccordion(
140140
var contentDiv = new TagBuilder("div");
141141
contentDiv.MergeCssClass("govuk-accordion__section-content");
142142
contentDiv.Attributes.Add("id", contentId);
143-
contentDiv.Attributes.Add("aria-labelledby", headingId);
144143
contentDiv.MergeOptionalAttributes(item.ContentAttributes);
145144
contentDiv.InnerHtml.AppendHtml(item.Content);
146145
section.InnerHtml.AppendHtml(contentDiv);

test/GovUk.Frontend.AspNetCore.Tests/TagHelpers/AccordionTagHelperTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public async Task ProcessAsync_GeneratesExpectedOutput()
6767
</h1>
6868
<div class=""govuk-body govuk-accordion__section-summary"" id=""testaccordion-summary-1"">First summary</div>
6969
</div>
70-
<div aria-labelledby=""testaccordion-heading-1"" class=""govuk-accordion__section-content"" id=""testaccordion-content-1"">
70+
<div class=""govuk-accordion__section-content"" id=""testaccordion-content-1"">
7171
First content
7272
</div>
7373
</div>
@@ -77,7 +77,7 @@ First content
7777
<span class=""govuk-accordion__section-button"" id=""testaccordion-heading-2"">Second heading</span>
7878
</h1>
7979
</div>
80-
<div aria-labelledby=""testaccordion-heading-2"" class=""govuk-accordion__section-content"" id=""testaccordion-content-2"">
80+
<div class=""govuk-accordion__section-content"" id=""testaccordion-content-2"">
8181
First content
8282
</div>
8383
</div>
@@ -146,7 +146,7 @@ public async Task ProcessAsync_WithSectionTranslationAttributes_GeneratesExpecte
146146
</h2>
147147
<div class=""govuk-body govuk-accordion__section-summary"" id=""testaccordion-summary-1"">First summary</div>
148148
</div>
149-
<div aria-labelledby=""testaccordion-heading-1"" class=""govuk-accordion__section-content"" id=""testaccordion-content-1"">
149+
<div class=""govuk-accordion__section-content"" id=""testaccordion-content-1"">
150150
First content
151151
</div>
152152
</div>
@@ -156,7 +156,7 @@ First content
156156
<span class=""govuk-accordion__section-button"" id=""testaccordion-heading-2"">Second heading</span>
157157
</h2>
158158
</div>
159-
<div aria-labelledby=""testaccordion-heading-2"" class=""govuk-accordion__section-content"" id=""testaccordion-content-2"">
159+
<div class=""govuk-accordion__section-content"" id=""testaccordion-content-2"">
160160
First content
161161
</div>
162162
</div>

0 commit comments

Comments
 (0)