Address pylint issues flagged by newer pylint in github actions

Signed-off-by: Mark Syms <mark.syms@cloud.com>

Author: MarkSymsCtx

drivers/LUNperVDI.py

@@ -82,6 +82,7 @@ def create(self, sr_uuid, vdi_uuid, size):
         VDIs = util._getVDIs(self.sr)
         self.sr._loadvdis()
         smallest = 0
+        v = None
         for vdi in VDIs:
             if not vdi['managed'] \
                    and int(vdi['virtual_size']) >= int(size) \

drivers/LVHDSR.py

@@ -205,6 +205,7 @@ def load(self, sr_uuid):
             re.compile("^.*[0-9a-f]{8}-(([0-9a-f]{4})-){3}[0-9a-f]{12}.*")
         self.storageVDIs = {}
 
+        vdi = None
         for key in self.lvmCache.lvs.keys():
             # if the lvname has a uuid in it
             type = None
@@ -969,6 +970,7 @@ def _undoCloneOp(self, lvs, origUuid, baseUuid, clonUuid):
         origRefcountNormal = 0
 
         # un-hide the parent
+        vhdInfo = None
         if base.vdiType == vhdutil.VDI_TYPE_VHD:
             self.lvActivator.activate(baseUuid, base.name, False)
             origRefcountNormal = 1

drivers/SR.py

@@ -153,7 +153,8 @@ def __init__(self, srcmd, sr_uuid):
 
     @staticmethod
     def from_uuid(session, sr_uuid):
-        import imp
+        import importlib.machinery
+        import types
 
         _SR = session.xenapi.SR
         sr_ref = _SR.get_by_uuid(sr_uuid)
@@ -169,7 +170,9 @@ def from_uuid(session, sr_uuid):
         driver_real = os.path.realpath(driver_path)
         module_name = os.path.basename(driver_path)
 
-        module = imp.load_source(module_name, driver_real)
+        loader = importlib.machinery.SourceFileLoader(module_name, driver_real)
+        module = types.ModuleType(loader.name)
+        loader.exec_module(module)
         target = driver(sm_type)
         # NB. get the host pbd's device_config
 
@@ -186,6 +189,7 @@ def from_uuid(session, sr_uuid):
         # FIXME
 
         from SRCommand import SRCommand
+        # pylint:  disable=E1101
         cmd = SRCommand(module.DRIVER_INFO)
         cmd.dconf = device_config
         cmd.params = {'session_ref': session._session,

drivers/cleanup.py

@@ -3489,6 +3489,7 @@ def main():
     background = False
     force = False
     dryRun = False
+    maxAge = 0
     debug_cmd = ""
     vdi_uuid = ""
     shortArgs = "gGc:aqxu:bfdt:v:"

drivers/iscsilib.py

@@ -248,7 +248,7 @@ def get_node_config (portal, targetIQN):
     ini_sec = "root"
     str_fp = io.StringIO("[%s]\n%s" % (ini_sec, stdout))
     parser = RawConfigParser()
-    parser.readfp(str_fp)
+    parser.read_file(str_fp)
     str_fp.close()
     return dict(parser.items(ini_sec))
 

drivers/mpathcount.py

@@ -84,6 +84,7 @@ def match_dmpLUN(s):
 
 
 def match_pathup(s):
+    path_status = None
     match = re.match(r'.*\d+:\d+:\d+:\d+\s+\S+\s+\S+\s+\S+\s+(\S+)', s)
     if match:
         path_status = match.group(1)

drivers/resetvdis.py

@@ -21,6 +21,7 @@
 import cleanup
 import util
 import lock
+import sys
 import XenAPI # pylint: disable=import-error