misc(disk_perf): styling

Signed-off-by: Mathieu Labourier <[email protected]>

Author: Millefeuille42

tests/storage/benchmarks/conftest.py

@@ -6,7 +6,7 @@
 from lib.commands import SSHCommandFailed
 from .helpers import load_results_from_csv
 
-MAX_LENGTH = 64*(1024**3) # 64GiB
+MAX_LENGTH = 64 * (1024**3) # 64GiB
 
 # use vhd, qcow2, raw... when image_format support will be available
 @pytest.fixture(scope="module", params=['vdi'])
@@ -30,7 +30,8 @@ def running_unix_vm_with_fio(running_unix_vm):
             vm.ssh(install_cmd, check=True)
             remove_cmd = remove
             break
-        except SSHCommandFailed: ...
+        except SSHCommandFailed:
+            ...
     else:
         raise RuntimeError("Unsupported package manager: could not install fio")
 
@@ -100,4 +101,4 @@ def prev_results(request):
     results = {}
     if csv_path and os.path.exists(csv_path):
         load_results_from_csv(csv_path)
-    return results
+    return results

tests/storage/benchmarks/helpers.py

@@ -45,4 +45,4 @@ def load_results_from_csv(csv_path):
 def mean(data, key):
     return statistics.mean(
         [float(x[key]) for x in data if key in x]
-    )
+    )

tests/storage/benchmarks/test_disk_perf.py

@@ -9,7 +9,7 @@
 from lib.commands import SSHCommandFailed
 from .helpers import load_results_from_csv, log_result_csv, mean
 
-### Tests default settings ###
+# Tests default settings #
 
 CSV_FILE = f"/tmp/results_{datetime.now().strftime("%Y-%m-%d_%H:%M:%S")}.csv"
 
@@ -20,21 +20,21 @@
 DEFAULT_NUMJOBS = 1
 DEFAULT_FILE = "fio-testfile"
 
-### Tests parameters
+# Tests parameters #
 
 system_memory = os.sysconf('SC_PAGE_SIZE') * os.sysconf('SC_PHYS_PAGES')
 
 block_sizes = ("4k", "16k", "64k", "1M")
-file_sizes = ("1G", "4G", f"{int((system_memory//(1024.**3))*2)}G")
+file_sizes = ("1G", "4G", f"{int((system_memory // (1024.**3)) * 2)}G")
 
 modes = (
-        "read",
-        "randread",
-        "write",
-        "randwrite"
+    "read",
+    "randread",
+    "write",
+    "randwrite"
 )
 
-### End of tests parameters ###
+# End of tests parameters #
 
 def run_fio(
         vm,
@@ -87,7 +87,7 @@ def assert_performance_not_degraded(current, previous, threshold=10):
         except statistics.StatisticsError:
             logging.info(f"Missing metric ({metric}), skipping comparison")
             continue
-        diff = (curr-prev if metric == "latency" else prev-curr) / (prev * 100)
+        diff = (curr - prev if metric == "latency" else prev - curr) / (prev * 100)
         assert diff <= threshold, \
             f"{metric} changed by {diff:.2f}% (allowed {threshold}%)"
         diffs[metric] = diff
@@ -98,9 +98,6 @@ def assert_performance_not_degraded(current, previous, threshold=10):
         logging.info(f"- {k}: {sign}{abs(v):.2f}%")
 
 
-class TestDiskPerfDestroy: ...
-
-
 class TestDiskPerf:
     test_cases = itertools.product(block_sizes, file_sizes, modes)