Skip to content

Commit e49b468

Browse files
Abatomamd-xiaoyu12
authored andcommitted
[Bugfix][V1][P/D]Fix the uneven polling issue in the toy proxy for P2pNcclConnector (vllm-project#21819)
Signed-off-by: Abatom <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
1 parent f9751b5 commit e49b468

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

examples/online_serving/disaggregated_serving_p2p_nccl_xpyd/disagg_proxy_p2p_nccl_xpyd.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def _listen_for_register(poller, router_socket):
4646
global prefill_instances
4747
global prefill_cv
4848
with prefill_cv:
49-
node = prefill_instances.pop(data["http_address"], None)
49+
node = prefill_instances.get(data["http_address"], None)
5050
prefill_instances[data["http_address"]] = (
5151
data["zmq_address"],
5252
time.time() + DEFAULT_PING_SECONDS,
@@ -57,7 +57,7 @@ def _listen_for_register(poller, router_socket):
5757
global decode_instances
5858
global decode_cv
5959
with decode_cv:
60-
node = decode_instances.pop(data["http_address"], None)
60+
node = decode_instances.get(data["http_address"], None)
6161
decode_instances[data["http_address"]] = (
6262
data["zmq_address"],
6363
time.time() + DEFAULT_PING_SECONDS,
@@ -69,6 +69,7 @@ def _listen_for_register(poller, router_socket):
6969
remote_address,
7070
data,
7171
)
72+
return
7273

7374
if node is None:
7475
print(f"🔵Add [HTTP:{data['http_address']}, ZMQ:{data['zmq_address']}]")

0 commit comments

Comments
 (0)