Refactor: enforce internal log redirection and log file path on startup

Author: xihale

internal/app/install_windows.go

@@ -7,7 +7,6 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
-	"snirect/internal/config"
 	"snirect/internal/logger"
 )
 
@@ -22,14 +21,8 @@ func getBinPath() string {
 
 func installServicePlatform(binPath string) error {
 	taskName := "Snirect"
-	logPath := config.GetDefaultLogPath()
 
-	// Ensure log directory exists
-	if err := os.MkdirAll(filepath.Dir(logPath), 0755); err != nil {
-		logger.Warn("Failed to create log directory: %v", err)
-	}
-
-	cmd := exec.Command("schtasks", "/Create", "/TN", taskName, "/TR", fmt.Sprintf(`"cmd /c \"%s\" >> \"%s\" 2>&1"`, binPath, logPath),
+	cmd := exec.Command("schtasks", "/Create", "/TN", taskName, "/TR", fmt.Sprintf(`"%s"`, binPath),
 		"/SC", "ONLOGON", "/RL", "HIGHEST", "/F")
 
 	output, err := cmd.CombinedOutput()

internal/config/config.toml

@@ -24,7 +24,7 @@
 #
 # 自动设置系统代理
 # 启动时自动将 Snirect 设置为系统代理。
-set_proxy = true
+# set_proxy = true
 
 # [Root CA Installation]
 # Policy for automatically importing and trusting the Snirect Root CA.
@@ -118,10 +118,14 @@ set_proxy = true
 [log]
 # Log level: "DEBUG", "INFO", "WARN", "ERROR".
 # 日志级别: "DEBUG", "INFO", "WARN", "ERROR"。
-# loglevel = "DEBUG"
-# Path to the log file.
+# loglevel = "INFO"
+
 # 日志文件路径。
-# logfile = "log.txt"
+# 如果留空，将使用以下默认系统路径：
+#   Linux:   ~/.local/state/snirect/snirect.log
+#   macOS:   ~/Library/Logs/snirect/snirect.log
+#   Windows: %LOCALAPPDATA%\snirect\Logs\snirect.log
+# logfile = ""
 
 # [Server Settings]
 # Configuration for the Snirect proxy server itself.

internal/config/loader.go

@@ -89,8 +89,6 @@ func LoadConfig(path string) (*Config, error) {
 		return nil, fmt.Errorf("failed to parse default config: %w", err)
 	}
 
-	// Set default log file path if empty (from defaults or user override)
-	// We do it here initially in case user config doesn't exist
 	if cfg.Log.File == "" {
 		cfg.Log.File = GetDefaultLogPath()
 	}

internal/logger/logger.go

@@ -62,34 +62,27 @@ func updateLogger(path string) {
 	}
 	writers = append(writers, consoleWriter)
 
+	// Ensure directory exists if path is provided
 	if path != "" {
 		if err := os.MkdirAll(filepath.Dir(path), 0755); err != nil {
 			fmt.Fprintf(os.Stderr, "Failed to create log directory: %v\n", err)
 		}
 		f, err := os.OpenFile(path, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
 		if err == nil {
-			// For file output, use standard JSON or Text handler for better machine readability, or simple text
-			// Using basic text handler for file to keep it simple but structured
 			writers = append(writers, f)
 		} else {
 			fmt.Fprintf(os.Stderr, "Failed to open log file: %v\n", err)
 		}
 	}
 
-	// We need a custom handler that writes formatted text to console and standard log to file
-	// Since slog.New takes one handler, we'll wrap them using a MultiHandler approach
-	// or simplify by just using our custom handler for console and writing directly to file if needed.
-	// However, standard slog doesn't support multi-handlers out of the box easily without libraries.
-	// Let's implement a simple wrapper handler.
-
 	handler := &MultiHandler{
 		console: consoleWriter,
 		file:    nil,
 		level:   logLevel,
 	}
 
+	// If a file writer was added, it's the second writer
 	if len(writers) > 1 {
-		// File writer is the second one
 		handler.file = slog.NewTextHandler(writers[1], &slog.HandlerOptions{
 			Level: logLevel,
 			ReplaceAttr: func(groups []string, a slog.Attr) slog.Attr {
@@ -102,6 +95,12 @@ func updateLogger(path string) {
 	}
 
 	currentLogger = slog.New(handler)
+
+	// Log the initial path info only if file logging is enabled
+	if len(writers) > 1 {
+		absPath, _ := filepath.Abs(path)
+		currentLogger.Info(fmt.Sprintf("Logging to file: %s", absPath))
+	}
 }
 
 // MultiHandler dispatches to console (custom) and file (standard text)