trying to optimise count in map view even more

Author: MartinHinz

app/controllers/xronos_data_controller.rb

@@ -39,6 +39,27 @@ def index
       # HTML (/data)
       # ---------------------------
       format.html do
+        if unfiltered_request?
+          # Unfiltered case: we only need one count,
+          # and filtered == total. Cache it.
+          base_relation = @data.everything.except(:select, :includes, :order)
+
+          @total_count = @filtered_count =
+            Rails.cache.fetch(cache_key_for("total_count"), expires_in: 10.minutes) do
+              base_relation.distinct.count(:id)
+            end
+        else
+          # Filtered case: we need both numbers
+          filtered_relation = @data.xrons.except(:select, :includes, :order)
+          total_relation    = @data.everything.except(:select, :includes, :order)
+
+          @filtered_count = filtered_relation.distinct.count(:id)
+          @total_count    = Rails.cache.fetch(cache_key_for("total_count"), expires_in: 10.minutes) do
+            total_relation.distinct.count(:id)
+          end
+        end
+
+        # your existing includes + pagination
         xrons_relation = @data.xrons.includes(
           sample: [
             :material,

app/views/xronos_data/_filter_status.html.erb

@@ -1,8 +1,11 @@
 <% if @data.filters.any? %>
-  <span class="<%= @data.xrons.any? ? "text-success" : "text-danger" %>">
-    Showing <%= @data.xrons.count %> of <%= @data.everything.count %> records
+  <span class="<%= @xrons.any? ? "text-success" : "text-danger" %>">
+    Showing <%= number_with_delimiter(@filtered_count) %>
+    of <%= number_with_delimiter(@total_count) %> records
     (<%= link_to "clear filters", :data %>)
   </span>
 <% else %>
-  <span class="text-dark">Showing <%= @data.everything.count %> records</span>
-<% end %>
+  <span class="text-dark">
+    Showing <%= number_with_delimiter(@total_count) %> records
+  </span>
+<% end %>

app/views/xronos_data/index.html.erb

@@ -1,7 +1,6 @@
 <% content_for :title, "Browse data" %>
-<% record_count = @pagy&.count || @xrons.size %>
 <% content_for :meta_description,
-   "Browse and download #{record_count} chronometric records from XRONOS, including radiocarbon dates, typological classifications, and dendrochronological dates. Filter by countries, specific archaeological site(s), site types, sample materials, sample taxa, radiocarbon laboratories, or laboratory IDs." %>
+  "Browse and download #{@total_count} chronometric records from XRONOS, including radiocarbon dates, typological classifications, and dendrochronological dates. Filter by countries, specific archaeological site(s), site types, sample materials, sample taxa, radiocarbon laboratories, or laboratory IDs." %>
 
 <div class="px-1 py-2 border-bottom shadow-sm">
   <%= render "toolbar" %>