Incompatible with Sqlalchemy v2.0.44 using asynch

[nils-borrmann-tacto]

On Sqlalchemy v2.0.44 I am running into the following error:

        if is_cursor and cursor_result.cursor is not None:
>           await cursor_result.cursor._async_soft_close()
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E           AttributeError: 'AsyncAdapt_asynch_cursor' object has no attribute '_async_soft_close'

This is caused by this commit in sqlalchemy: sqlalchemy/sqlalchemy@2e9902a

A fix could be to either add an empty method _async_soft_close() to AsyncAdapt_asynch_cursor; or to make it inherit from AsyncAdapt_dbapi_cursor and set _awaitable_cursor_close: bool = False.

[Telemaco019]

In case it helps, we’re maintaining this fork for compatibility with the latest versions of SQLAlchemy and async: https://github.com/nebuly-ai/clickhouse-sqlalchemy

[nils-borrmann-tacto]

@Telemaco019 Yeah, I saw. I'm actually using your version already. Thanks!

But it doesn't solve this particular issue, I also encounter this issue with your fork.

[Telemaco019]

I just noticed we had the same issue with SQLAlchemy 2.0.44 😅

We've now fixed it here by making AsyncAdapt_asynch_cursor inherit from AsyncAdapt_dbapi_cursor as you suggested. @nils-borrmann-tacto Thanks a lot! 🙌

[9en9i]

@Telemaco019 Hello, could you please tell me if you opened a PR? I also encountered this problem.

[Telemaco019]

Hi @9en9i! No I didn't open a PR, I fixed the issue only in the forked repo

[9en9i]

@Telemaco019 Are there any reasons why you wouldn't open a PR?

[Telemaco019]

This repo seemed unmaintained at the time

[9en9i]

Let's try to open a PR? Maybe the author will be able to find time for it.